Skip to content

chore: Match the AppHost SDK to Aspire.Hosting.AppHost 13.6.4 - #453

Merged
mpaulosky merged 1 commit into
dependabot/nuget/main/all-nuget-0ec548cd9cfrom
chore/aspire-sdk-13-6-4
Nov 1, 2026
Merged

mpaulosky merged 1 commit into
dependabot/nuget/main/all-nuget-0ec548cd9cfrom
chore/aspire-sdk-13-6-4

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Fixes the failing Architecture.Tests check on #452.

#452 bumps Aspire.Hosting.AppHost to 13.6.4, but src/AppHost/AppHost.csproj still pinned Aspire.AppHost.Sdk/13.6.1. AppHostCsproj_SdkVersion_MatchesAspireHostingAppHostPackageVersion requires the two to match.

This PR targets #452's branch, because the pre-push hook rejects pushes to dependabot/* branch names. Merge it into that branch, then #452 can go green.

Local checks: the gate passes, and Architecture.Tests passes 129 of 129. The pre-push review found nothing. No new packages.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 1, 2026 17:33
@mpaulosky mpaulosky assigned Copilot and unassigned Copilot Nov 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The AppHost SDK version alignment has no active review issues.

No open issues 🎉

What changed in this PR

Aligns the template’s AppHost SDK with the Aspire.Hosting.AppHost update in #452, addressing the reported architecture-test version mismatch.

Changes:

  • Updates Aspire.AppHost.Sdk from 13.6.1 to 13.6.4 without adding packages or changing application code.
File Description
src/​AppHost/​AppHost.csproj Updates the SDK pin to match the hosting package version in #452.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Test Results Summary

660 tests  ±0   660 ✅ +1   1m 4s ⏱️ +7s
  6 suites ±0     0 💤 ±0 
  6 files   ±0     0 ❌  - 1 

Results for commit 4433e7b. ± Comparison against base commit 2b28a50.

@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.65%. Comparing base (2b28a50) to head (4433e7b).

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                             @@
##           dependabot/nuget/main/all-nuget-0ec548cd9c     #453   +/-   ##
===========================================================================
  Coverage                                       96.65%   96.65%           
===========================================================================
  Files                                              42       42           
  Lines                                             568      568           
  Branches                                          100      100           
===========================================================================
  Hits                                              549      549           
  Misses                                              5        5           
  Partials                                           14       14           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpaulosky
mpaulosky merged commit 8d33def into dependabot/nuget/main/all-nuget-0ec548cd9c Nov 1, 2026
23 checks passed
@mpaulosky
mpaulosky deleted the chore/aspire-sdk-13-6-4 branch November 1, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants