Skip to content

fix(sandcastle): Run the YAML, workflow and shell lints in the sandbox check - #329

Merged
mpaulosky merged 2 commits into
mainfrom
chore/check-sh-lints
Oct 26, 2026
Merged

mpaulosky merged 2 commits into
mainfrom
chore/check-sh-lints

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

.sandcastle/check.sh is the gate the host runs in the sandbox (GATE_COMMAND), but it ran only markdownlint of the gate's lints. The Dockerfile installs yamllint, actionlint, shellcheck and zizmor, and nothing used them, so a branch that broke a workflow, YAML file or shell script passed both checkpoints and failed CI's lint workflows afterwards.

  • check.sh now runs the same lints as scripts/gate.sh: yamllint on the changed YAML, actionlint and zizmor --offline --min-severity medium . when a workflow changed, and shellcheck on the changed shell scripts. A tool that isn't installed (a run outside the image) is skipped with a warning, as the gate does.
  • Its header comment now says which tools the image provides, instead of that it lacks them.

From a Claude Review thread on #324 (.sandcastle/Dockerfile, line 30).

🤖 Generated with Claude Code

…x check

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Test Results Summary

880 tests   874 ✅  1m 40s ⏱️
  7 suites    6 💤
  7 files      0 ❌

Results for commit f92e4ea.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.42%. Comparing base (62efa3c) to head (f92e4ea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         117      117           
  Lines        2717     2717           
  Branches      387      387           
=======================================
  Hits         2321     2321           
  Misses        318      318           
  Partials       78       78           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpaulosky
mpaulosky merged commit 51c712b into main Oct 26, 2026
34 checks passed
@mpaulosky
mpaulosky deleted the chore/check-sh-lints branch October 26, 2026 14:59
mpaulosky added a commit that referenced this pull request Oct 26, 2026
Automated release blog posts for #328, #329, #330, opened by the release
workflow. It holds every Release whose post isn't on main yet, rebuilt
from main on each run. The [skip-release] title marker keeps its merge
from starting another release.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant