Repository navigation
fix(sandcastle): Run the YAML, workflow and shell lints in the sandbox check - #329
Merged
Merged
Conversation
…x check Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Test Results Summary880 tests 874 ✅ 1m 40s ⏱️ Results for commit f92e4ea. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 85.42% 85.42%
=======================================
Files 117 117
Lines 2717 2717
Branches 387 387
=======================================
Hits 2321 2321
Misses 318 318
Partials 78 78 🚀 New features to boost your workflow:
|
mpaulosky
added a commit
that referenced
this pull request
Oct 26, 2026
Automated release blog posts for #328, #329, #330, opened by the release workflow. It holds every Release whose post isn't on main yet, rebuilt from main on each run. The [skip-release] title marker keeps its merge from starting another release. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.sandcastle/check.shis the gate the host runs in the sandbox (GATE_COMMAND), but it ran only markdownlint of the gate's lints. The Dockerfile installs yamllint, actionlint, shellcheck and zizmor, and nothing used them, so a branch that broke a workflow, YAML file or shell script passed both checkpoints and failed CI's lint workflows afterwards.check.shnow runs the same lints asscripts/gate.sh: yamllint on the changed YAML, actionlint andzizmor --offline --min-severity medium .when a workflow changed, and shellcheck on the changed shell scripts. A tool that isn't installed (a run outside the image) is skipped with a warning, as the gate does.From a Claude Review thread on #324 (
.sandcastle/Dockerfile, line 30).🤖 Generated with Claude Code