Skip to content

chore: Re-apply the repo-ci-baseline Template - #332

Merged
mpaulosky merged 2 commits into
mainfrom
chore/reapply-baseline
Oct 26, 2026
Merged

mpaulosky merged 2 commits into
mainfrom
chore/reapply-baseline

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Why

Re-Apply the repo-ci-baseline Template so this repo carries the Template changes from mpaulosky/dotfiles#303, #304, #305 and #306: the opt-in UI developer role, the narrowed long-run credential redaction in Claude Review's script, the shared ui-role test helper and the retried scratch-directory cleanup in the Sandcastle tests.

What changed

  • 2a179eb Apply commit, apply.sh output alone: 22 Owned files (byte-identical to the Template's) and one new Seed file, .sandcastle/roles/ui.md, the UI developer's prompt, which stays unused here: this repo has no ui entry in ROLE_AGENTS.
  • 17e8da3 Takes the UI developer line in .sandcastle/roles/backend.md from the Seed: the Owned lib/prompts.mts always passes UI_DEVELOPER, so a backend prompt without the placeholder logged an unreferenced-argument warning on every run. With no ui entry the line renders the sentence it had before.

Verification

  • The pre-push gate (scripts/gate.sh) passed.
  • The Seed file makes this more than an Owned-only change, so it went through the local /pre-push-review: 1 round, no findings.

🤖 Generated with Claude Code

mpaulosky and others added 2 commits October 26, 2026 14:06
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rom the Template

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test Results Summary

880 tests  ±0   874 ✅ ±0   1m 33s ⏱️ ±0s
  7 suites ±0     6 💤 ±0 
  7 files   ±0     0 ❌ ±0 

Results for commit 17e8da3. ± Comparison against base commit a5231ed.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.42%. Comparing base (a5231ed) to head (17e8da3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         117      117           
  Lines        2717     2717           
  Branches      387      387           
=======================================
  Hits         2321     2321           
  Misses        318      318           
  Partials       78       78           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpaulosky mpaulosky added the review:claude Claude reviews each head, a backup to Copilot's review label Oct 26, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Review

Overview

This PR does two things:

  • It narrows the long-token redaction rule in post_claude_review.py and its inline copy in claude-review.yml, so only long tokens that contain a credential start are replaced.
  • It adds an opt-in ui (UI developer) Sandcastle role, with fixtures and tests.

The redaction change is sound. Every CREDENTIAL alternative needs one of the listed starts inside a single token chain, so no credential escapes, and the scan stays linear. The ui wiring (uiEnabled, resolveRoles, buildIssue, backendPromptArgs) also looks correct. I found one blocking-worthy problem: the shipped roles/ui.md has no # SKILLS section, so the new skills/prompt consistency test fails for any repo that opts in.

Changes

File What changed
.github/scripts/post_claude_review.py, .github/workflows/claude-review.yml CREDENTIAL_START added. The long-run replacement now requires a credential start in the chain. The workflow copy is kept in sync.
.github/scripts/tests/test_post_claude_review.py Tests for long plain tokens left alone, long credential starts still replaced, script and workflow parity, and every CREDENTIAL match containing a start.
.sandcastle/lib/agents.mts, config.mts, plan.mts, build.mts, prompts.mts AnyRole/OptInRole, uiEnabled, roleAgent, and ui in OPTIONAL_ROLES and BUILD_ROLES. resolveRoles drops ui when not enabled. buildIssue runs ui after the backend. backendPromptArgs sets UI_DEVELOPER.
.sandcastle/roles/backend.md, roles/ui.md backend.md uses {{UI_DEVELOPER}}. ui.md is a new prompt.
.sandcastle/lib/ui-role-fixture.mts and tests (agents, build, config, plan, skills, ui-role-fixture) withUiRole fixture, ui build tests, a prompt/skills consistency test, and a config check.
Many *.test.mts, git-sandbox-fake.mts rmSync now retries (maxRetries: 5, retryDelay: 100).
.sandcastle/main.mts Header comment updated.

Advisory (not blocking)

  • The ui role's prompt-existence checks in config.test.mts and skills.test.mts are skipped in this repo, because ui is not opted in. Nothing in CI exercises the opt-in path against the real ui.md. That is how the finding went unnoticed.
  • withUiRole mutates the shared ROLE_AGENTS object, and delete agents.ui would throw in strict ESM if ROLE_AGENTS were ever frozen.
  • backend.md now requires {{UI_DEVELOPER}} unconditionally. I could not confirm that backendPromptArgs is the only thing that renders backend.md. If anything else renders it, Sandcastle rejects the missing placeholder.
  • ui.md says little about what to do when a tester's test is wrong rather than the code, beyond "leave it and say why in your commit body".

Not reviewed

I did not read AGENTS.md, CLAUDE.md, repo-config.mts, plan-prompt.md, or the host() helper in build.test.mts. Statements about them are inferred from the diff and the context pieces.

Comment thread .sandcastle/roles/ui.md Resolved
@mpaulosky
mpaulosky merged commit d79df5b into main Oct 26, 2026
35 checks passed
@mpaulosky
mpaulosky deleted the chore/reapply-baseline branch October 26, 2026 21:27
mpaulosky added a commit that referenced this pull request Oct 26, 2026
Automated release blog posts for #332, opened by the release workflow.
It holds every Release whose post isn't on main yet, rebuilt from main
on each run. The [skip-release] title marker keeps its merge from
starting another release.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:claude Claude reviews each head, a backup to Copilot's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant