Skip to content

chore(deps): Bump Aspire to 13.6.5 for security advisories - #345

Merged
mpaulosky merged 1 commit into
mainfrom
chore/bump-aspire-13-6-5
Nov 18, 2026
Merged

mpaulosky merged 1 commit into
mainfrom
chore/bump-aspire-13-6-5

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Requested by Matthew · project thread

Why

Aspire 13.6.4 and older carry GHSA-4g86-54fm-h9h8 (critical) and GHSA-f7vh-h5g3-7jrh (high). The -warnaserror restore fails on NU1903/NU1904, so every open PR here is red. 13.6.5 is the patched release.

What changed

  • Directory.Packages.props: Aspire.AppHost.Sdk, Aspire.Hosting, Aspire.Hosting.MongoDB, Aspire.Hosting.Redis, Aspire.Hosting.Testing and Aspire.StackExchange.Redis.OutputCaching move to 13.6.5 (from 13.6.1/13.6.4).
  • src/AppHost/AppHost.csproj: Aspire.AppHost.Sdk 13.6.1 → 13.6.5.

Verification

  • dotnet build IssueManager.slnx -c Release -warnaserror: 0 warnings, 0 errors.
  • CI runs the tests.

Generated by Claude Code

Aspire 13.6.4 and older carry GHSA-4g86-54fm-h9h8 (critical) and
GHSA-f7vh-h5g3-7jrh (high), which fail the -warnaserror restore with
NU1903/NU1904 and turn every PR red. 13.6.5 is the patched release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KKGWRKHdNBDvVoVhhhEL4g
@mpaulosky mpaulosky self-assigned this Nov 18, 2026
@mpaulosky
mpaulosky marked this pull request as ready for review November 18, 2026 17:17
@github-actions

Copy link
Copy Markdown
Contributor

Test Results Summary

880 tests   874 ✅  1m 31s ⏱️
  7 suites    6 💤
  7 files      0 ❌

Results for commit ded96ee.

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.42%. Comparing base (306eb0d) to head (ded96ee).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         117      117           
  Lines        2717     2717           
  Branches      387      387           
=======================================
  Hits         2321     2321           
  Misses        318      318           
  Partials       78       78           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpaulosky mpaulosky added the review:claude Claude reviews each head, a backup to Copilot's review label Nov 18, 2026 — with Claude

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Review

Overview

This PR moves every Aspire package in Directory.Packages.props to 13.6.5. It also moves the Aspire.AppHost.Sdk version in AppHost.csproj to 13.6.5, and the commit message cites security advisories. The diff is mechanical and I found nothing that should block the merge. I read both diff pieces and the context piece. I did not check the package versions against the NuGet feed, and the restore and build in CI is the check that confirms they exist.

Changes

File What changed
Directory.Packages.props Aspire.AppHost.Sdk goes from 13.6.1 to 13.6.5. Aspire.Hosting, .MongoDB, .Redis and .Testing go from 13.6.4 to 13.6.5. Aspire.StackExchange.Redis.OutputCaching goes from 13.6.1 to 13.6.5.
src/AppHost/AppHost.csproj The SDK in the Project Sdk="Aspire.AppHost.Sdk/…" attribute goes from 13.6.1 to 13.6.5.

Advisory (not blocking)

  • The SDK version is now pinned in two places: the PackageVersion entry in Directory.Packages.props and the Sdk= attribute in AppHost.csproj. The Sdk= attribute is the one MSBuild resolves. Both were bumped together here, but they can drift apart in later bumps.
  • Aspire.StackExchange.Redis.OutputCaching and the SDK were on 13.6.1 while the hosting packages were on 13.6.4. That suggests those packages hadn't been published for 13.6.2 to 13.6.4. I couldn't check that 13.6.5 exists for Aspire.StackExchange.Redis.OutputCaching or Aspire.AppHost.Sdk. If either is missing, dotnet restore in the Build job fails, so a green CI confirms it.
  • src/AppHost/AppHost.csproj still carries the ASPIRE010 suppression, with a comment saying to remove it once that's resolved. Check that 13.6.5 doesn't add other warnings, since CI builds with -warnaserror. The Build job will show this.

No findings.

@mpaulosky
mpaulosky merged commit 5727a09 into main Nov 18, 2026
40 checks passed
@mpaulosky
mpaulosky deleted the chore/bump-aspire-13-6-5 branch November 18, 2026 17:55
mpaulosky added a commit that referenced this pull request Nov 18, 2026
Automated release blog posts for #345, opened by the release workflow.
It holds every Release whose post isn't on main yet, rebuilt from main
on each run. The [skip-release] title marker keeps its merge from
starting another release.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:claude Claude reviews each head, a backup to Copilot's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants