Repository navigation
chore(deps): Bump Aspire to 13.6.5 for security advisories - #345
Conversation
Aspire 13.6.4 and older carry GHSA-4g86-54fm-h9h8 (critical) and GHSA-f7vh-h5g3-7jrh (high), which fail the -warnaserror restore with NU1903/NU1904 and turn every PR red. 13.6.5 is the patched release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KKGWRKHdNBDvVoVhhhEL4g
Test Results Summary880 tests 874 ✅ 1m 31s ⏱️ Results for commit ded96ee. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 85.42% 85.42%
=======================================
Files 117 117
Lines 2717 2717
Branches 387 387
=======================================
Hits 2321 2321
Misses 318 318
Partials 78 78 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Claude Review
Overview
This PR moves every Aspire package in Directory.Packages.props to 13.6.5. It also moves the Aspire.AppHost.Sdk version in AppHost.csproj to 13.6.5, and the commit message cites security advisories. The diff is mechanical and I found nothing that should block the merge. I read both diff pieces and the context piece. I did not check the package versions against the NuGet feed, and the restore and build in CI is the check that confirms they exist.
Changes
| File | What changed |
|---|---|
Directory.Packages.props |
Aspire.AppHost.Sdk goes from 13.6.1 to 13.6.5. Aspire.Hosting, .MongoDB, .Redis and .Testing go from 13.6.4 to 13.6.5. Aspire.StackExchange.Redis.OutputCaching goes from 13.6.1 to 13.6.5. |
src/AppHost/AppHost.csproj |
The SDK in the Project Sdk="Aspire.AppHost.Sdk/…" attribute goes from 13.6.1 to 13.6.5. |
Advisory (not blocking)
- The SDK version is now pinned in two places: the
PackageVersionentry inDirectory.Packages.propsand theSdk=attribute inAppHost.csproj. TheSdk=attribute is the one MSBuild resolves. Both were bumped together here, but they can drift apart in later bumps. Aspire.StackExchange.Redis.OutputCachingand the SDK were on 13.6.1 while the hosting packages were on 13.6.4. That suggests those packages hadn't been published for 13.6.2 to 13.6.4. I couldn't check that 13.6.5 exists forAspire.StackExchange.Redis.OutputCachingorAspire.AppHost.Sdk. If either is missing,dotnet restorein the Build job fails, so a green CI confirms it.src/AppHost/AppHost.csprojstill carries theASPIRE010suppression, with a comment saying to remove it once that's resolved. Check that 13.6.5 doesn't add other warnings, since CI builds with-warnaserror. The Build job will show this.
No findings.
Automated release blog posts for #345, opened by the release workflow. It holds every Release whose post isn't on main yet, rebuilt from main on each run. The [skip-release] title marker keeps its merge from starting another release. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Requested by Matthew · project thread
Why
Aspire 13.6.4 and older carry GHSA-4g86-54fm-h9h8 (critical) and GHSA-f7vh-h5g3-7jrh (high). The
-warnaserrorrestore fails on NU1903/NU1904, so every open PR here is red. 13.6.5 is the patched release.What changed
Directory.Packages.props: Aspire.AppHost.Sdk, Aspire.Hosting, Aspire.Hosting.MongoDB, Aspire.Hosting.Redis, Aspire.Hosting.Testing and Aspire.StackExchange.Redis.OutputCaching move to 13.6.5 (from 13.6.1/13.6.4).src/AppHost/AppHost.csproj:Aspire.AppHost.Sdk13.6.1 → 13.6.5.Verification
dotnet build IssueManager.slnx -c Release -warnaserror: 0 warnings, 0 errors.Generated by Claude Code