Repository navigation
chore(sandcastle): Rename the sandbox gate to sandbox-gate.sh - #347
Conversation
The repo-ci-baseline Template now owns .sandcastle/check.sh as Sandcastle's check for the local gate, and Apply keeps this repo's copy while GATE_COMMAND and GATE_SCRIPT name it. Rename the repo's Docker-free sandbox gate to .sandcastle/sandbox-gate.sh and point both constants and every mention at it, so the next re-Apply can bring in the Owned check.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KKGWRKuqUVhPuDDxfXLWYP
…les.md The Owned role prompts the next re-Apply brings say to run scripts/gate.sh, which needs Docker. Say in the repo-owned shared-rules.md that in the sandbox it means .sandcastle/sandbox-gate.sh, describe what that gate runs, and pin the gate's name, its file and the note in repo-scripts.test.mts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KKGWRKuqUVhPuDDxfXLWYP
…dbox gate repo-scripts.test.mts asserted that .sandcastle/check.sh is absent, but the next re-Apply writes the Template's Owned check.sh once no gate constant names it, which would turn the Sandcastle check red. Pin only that the gate script is committed and isn't named check.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KKGWRKuqUVhPuDDxfXLWYP
Test Results Summary880 tests 874 ✅ 1m 40s ⏱️ Results for commit 953698f. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Claude Review
Overview
PR #347 renames the Docker-free sandbox gate from .sandcastle/check.sh to .sandcastle/sandbox-gate.sh. The script body is byte-for-byte unchanged apart from one comment. GATE_COMMAND and GATE_SCRIPT now point at the new name, and the role prompts, coding standards and gate-checks.sh messages follow. Two additions: a note in shared-rules.md that a role prompt's scripts/gate.sh means the sandbox gate inside the sandbox, and a new test file pinning the rename. I found no blocking problems, so there are no findings. I read the whole diff but could not search the rest of the repo for leftover references to check.sh.
Changes
| File | What changed |
|---|---|
.sandcastle/check.sh → .sandcastle/sandbox-gate.sh |
Renamed, mode 100755 kept. Only the comment that named the script changed (check.sh runs the Sandcastle tests… is now sandbox-gate.sh runs…). Lints, repo checks, build, non-Docker tests and check:sandcastle are the same as before. |
.sandcastle/lib/repo-config.mts |
GATE_COMMAND and GATE_SCRIPT now name .sandcastle/sandbox-gate.sh, and the comments were updated. CHECK_PATHS still covers the file through .sandcastle/. |
.github/ci/gate-checks.sh |
Comment and echo text now say sandbox-gate.sh. The SANDCASTLE_CHECK logic is unchanged. |
.sandcastle/repo-scripts.test.mts (new) |
Tests that the constants name the new file, that the file exists, that CHECK_PATHS covers it, and that shared-rules.md contains the scripts/gate.sh mapping sentence. |
.sandcastle/CODING_STANDARDS.md, review-prompt.md, roles/follow-up.md, roles/gate-fixer.md |
Name the new script. |
.sandcastle/roles/shared-rules.md |
Name the new script, and add a bullet mapping a role prompt's scripts/gate.sh to the sandbox gate. |
Advisory (not blocking)
follow-up.mdandgate-fixer.mdare role prompts, andshared-rules.mdandrepo-scripts.test.mtsdescribe such prompts as Template-Owned. The new test comment saysshared-rules.md"survives the next re-Apply". If the Template ownsfollow-up.md,gate-fixer.mdorreview-prompt.md, the next Apply may put their old text back. The newshared-rules.mdbullet is what keeps agents on the right script in that case, which fits the design.- I couldn't check which files are Owned. Look at the Template's Owned list. Any hand edit to an Owned prompt will be lost on re-Apply, and the follow-up role is told not to edit such files.
- In
repo-scripts.test.mts,assert.notEqual(GATE_SCRIPT, ".sandcastle/check.sh")repeats what the first test already proves, because that test pinsGATE_SCRIPTto the new name. The test name also claims more than it checks. The comment on that test admits that only the name is pinned. - The same file's
CHECK_PATHStest passes before and after the rename, as its own comment says. It only guards later edits toCHECK_PATHS. repo-config.mtsand the test file now have comment lines well over the surrounding width. This is cosmetic.- The accepted review note covers old branches failing the host gate until
mainis merged in. I did not re-raise it. Nothing in the diff changes that reasoning. - I could not search for other
.sandcastle/check.shreferences, such aslib/*.mtscode or tests, a Dockerfile or docs. The context pieces show none. The PR author's own tests should catch a missed reference.
No findings.
Automated release blog posts for #347, opened by the release workflow. It holds every Release whose post isn't on main yet, rebuilt from main on each run. The [skip-release] title marker keeps its merge from starting another release. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Requested by Matthew · project thread
Why
The repo-ci-baseline Template now owns
.sandcastle/check.shas Sandcastle's check for the local gate. This repo uses its own.sandcastle/check.shas theDocker-free sandbox gate, so
apply.shkeeps the repo's copy and reports a conflict. The Template'sreferences/sandcastle.md(steps 8 and 9) says to renamethe gate to
.sandcastle/sandbox-gate.shin a PR that merges before the next re-Apply. This is that PR, ahead of the November Baseline Rollout.What changed
.sandcastle/check.shis renamed to.sandcastle/sandbox-gate.sh, andGATE_COMMANDandGATE_SCRIPTin.sandcastle/lib/repo-config.mtsname it. One comment inside the script names its new file.review-prompt.md,roles/follow-up.md,roles/gate-fixer.md) name the new file, so Sandcastle keeps working until the re-Apply replaces them.roles/shared-rules.mdsays that a role prompt'sscripts/gate.shmeans.sandcastle/sandbox-gate.shin the sandbox, as TicketManager's does, so the Template's prompts work after the re-Apply..sandcastle/CODING_STANDARDS.mdand.github/ci/gate-checks.sh(a comment and an echo) name the new file..sandcastle/repo-scripts.test.mtspins the gate's name, that its file is committed, thatCHECK_PATHScovers it, and theshared-rules.mdnote.It doesn't require
check.shto be absent, since the re-Apply writes the Template'scheck.shbeside the gate.Verification
apply.sh --dry-runagainst this branch reports no conflicts.scripts/gate.shpasses (the pre-push hook ran it), includingpnpm run check:sandcastleand the E2E tests.Review notes
The local review raised these and they were accepted, not changed:
Generated by Claude Code