Repository navigation
ci: Run code metrics by hand and drop unused Auth0 settings - #148
Merged
Merged
Conversation
The metrics action doesn't count members of classes declared with a primary constructor, and every service and repository in src/ uses one, so its reports show them as empty. It now runs only on demand, as in atelier-store, and the misleading root CODE_METRICS.md from #142 is removed. Nothing in src/ or tests/ reads the Auth0 settings the test job set (the app signs in with Azure AD B2C), so they're removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The functional changes are focused and correct; only stale workflow comments remain.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Restricts unreliable code-metrics generation to manual runs and removes unused Auth0 test configuration.
Changes:
- Makes code metrics manually dispatched only.
- Removes obsolete Auth0 CI secrets and the misleading generated report.
| File | Description |
|---|---|
.github/workflows/code-metrics.yml |
Removes automatic triggers. |
.github/workflows/ci.yml |
Removes unused Auth0 settings. |
CODE_METRICS.md |
Deletes inaccurate generated metrics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 85.13% 85.13%
=======================================
Files 77 77
Lines 1561 1561
Branches 143 143
=======================================
Hits 1329 1329
Misses 189 189
Partials 43 43 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mpaulosky
added a commit
that referenced
this pull request
Sep 29, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
src/use one, so the reports show them as empty.code-metrics.ymlnow runs onworkflow_dispatchonly, as in atelier-store, and I've removed the misleading rootCODE_METRICS.mdthat Created CODE_METRICS.md file, analyzed metrics for 17 projects. [skip-release] #142 added (nothing linked to it). This corrects my earlier statement on ci: Adopt atelier-store's CI, release and lint setup #140 that IssueTracker had no primary constructors.Auth0__*,Auth0Management__*andParameters__auth0Mgmt*from repo secrets, but nothing insrc/ortests/reads them; the app signs in with Azure AD B2C. The 11AUTH0_*repo secrets can be deleted once this merges.Validation
scripts/gate.sh: lint, build and all test projects pass (including AppHost.Tests without the Auth0 values)🤖 Generated with Claude Code