Skip to content

ci: Run code metrics by hand and drop unused Auth0 settings - #148

Merged
mpaulosky merged 6 commits into
mainfrom
chore/code-metrics-manual
Sep 29, 2026
Merged

mpaulosky merged 6 commits into
mainfrom
chore/code-metrics-manual

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Summary

  • Code metrics run by hand only. The pinned metrics action doesn't count members of classes declared with a primary constructor. All 11 services and repositories in src/ use one, so the reports show them as empty. code-metrics.yml now runs on workflow_dispatch only, as in atelier-store, and I've removed the misleading root CODE_METRICS.md that Created CODE_METRICS.md file, analyzed metrics for 17 projects. [skip-release] #142 added (nothing linked to it). This corrects my earlier statement on ci: Adopt atelier-store's CI, release and lint setup #140 that IssueTracker had no primary constructors.
  • Unused Auth0 settings removed. The test job set Auth0__*, Auth0Management__* and Parameters__auth0Mgmt* from repo secrets, but nothing in src/ or tests/ reads them; the app signs in with Azure AD B2C. The 11 AUTH0_* repo secrets can be deleted once this merges.

Validation

  • yamllint, actionlint, zizmor: clean
  • Pre-push scripts/gate.sh: lint, build and all test projects pass (including AppHost.Tests without the Auth0 values)

🤖 Generated with Claude Code

The metrics action doesn't count members of classes declared with a
primary constructor, and every service and repository in src/ uses one,
so its reports show them as empty. It now runs only on demand, as in
atelier-store, and the misleading root CODE_METRICS.md from #142 is
removed.

Nothing in src/ or tests/ reads the Auth0 settings the test job set
(the app signs in with Azure AD B2C), so they're removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings September 29, 2026 19:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The functional changes are focused and correct; only stale workflow comments remain.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Restricts unreliable code-metrics generation to manual runs and removes unused Auth0 test configuration.

Changes:

  • Makes code metrics manually dispatched only.
  • Removes obsolete Auth0 CI secrets and the misleading generated report.
File Description
.github/​workflows/​code-metrics.yml Removes automatic triggers.
.github/​workflows/​ci.yml Removes unused Auth0 settings.
CODE_METRICS.md Deletes inaccurate generated metrics.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/code-metrics.yml Resolved
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Test Results Summary

449 tests  ±0   449 ✅ ±0   17s ⏱️ +3s
  9 suites ±0     0 💤 ±0 
  9 files   ±0     0 ❌ ±0 

Results for commit 06ccebe. ± Comparison against base commit ce88b6d.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (ce88b6d) to head (06ccebe).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files          77       77           
  Lines        1561     1561           
  Branches      143      143           
=======================================
  Hits         1329     1329           
  Misses        189      189           
  Partials       43       43           

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings September 29, 2026 19:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused workflow changes are consistent with current authentication usage and introduce no unresolved issues.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Copilot AI balanced review requested due to automatic review settings September 29, 2026 19:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The workflow changes are consistent with repository authentication usage and introduce no unresolved issues.

Review effort: Balanced
Findings: None

Copilot AI balanced review requested due to automatic review settings September 29, 2026 19:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Manual runs on main can still republish the known-inaccurate metrics report.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

Comment thread .github/workflows/code-metrics.yml Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings September 29, 2026 19:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The workflow remains securely pinned and the removed Auth0 settings have no consumers in source or tests.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Copilot AI balanced review requested due to automatic review settings September 29, 2026 19:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The workflow remains securely pinned and main-gated, while repository searches confirm the removed Auth0 settings are unused.

Review effort: Balanced
Findings: None

@mpaulosky
mpaulosky merged commit a166ce4 into main Sep 29, 2026
27 checks passed
@mpaulosky
mpaulosky deleted the chore/code-metrics-manual branch September 29, 2026 19:45
mpaulosky added a commit that referenced this pull request Sep 29, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants