Repository navigation
chore: Re-apply the repo-ci-baseline Template - #284
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage 85.63% 85.63%
=======================================
Files 75 75
Lines 1566 1566
Branches 186 186
=======================================
Hits 1341 1341
Misses 190 190
Partials 35 35 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Claude Review
Overview
This PR makes four changes:
- The review prompt now asks for a structured Markdown summary (Overview, Changes table, Advisory, Not reviewed) and a bold title on each finding.
post_claude_review.pyand the matching inline check in the workflow gain a bounded-time credential redaction. They also gain a path rule, which scans file names withCREDENTIALonly and applies the long-run rule only past 1024 characters.post_claude_review.pyvets GitHub one-click suggestions: one single-line suggestion on the cited line is kept, anything else becomes a```textfence. Off-diff findings are indented under their bullet.- Smaller fixes:
release_post.pystops splitting on U+2028/U+2029, and the SandcastleheadOfRefhelper picks the exactrefs/heads/<branch>line fromls-remote.
I found nothing that should block the merge. Having traced the regexes, the redaction ordering and the workflow/script mirroring, I believe they behave as the tests claim. I did not run the tests.
Changes
| File | What changed |
|---|---|
.github/workflows/claude-review.yml |
The prompt asks for a sectioned Markdown summary and titled findings. The inline answer check gains MAX_TOKEN_RUN, TOKEN_CHAIN, redact_credentials and redact_path. redact takes a key so path fields get the path rule. |
.github/scripts/post_claude_review.py |
Adds the same redaction. Adds SUGGESTION_FENCE, ONE_LINE_SUGGESTION, defuse_suggestions, suggestion_line_is_safe and vet_suggestions. Suggestions are defused on the nearest-line and off-diff paths. Off-diff bodies are indented under their bullet. |
.github/scripts/release_post.py |
_list, commit_subject and update_blog_index split on Markdown line endings only, not str.splitlines(). |
.sandcastle/lib/branches.mts, build.mts |
New headOfRef picks the exact-ref line. originRefs.remoteHead, remoteMainIs and remoteBranchIsOnOrigin use it. This fixes remoteHead returning the wrong commit when a tail-matching ref sorts first, which would have fed a wrong lease SHA to deleteRemote. |
test_post_claude_review.py, test_release_post.py, branches.test.mts, build.test.mts |
Tests for suggestion vetting, redaction (including linear-time and script/workflow parity checks), Unicode separators and headOfRef. |
Advisory (not blocking)
test_the_prompt_asks_for_a_structured_summary_and_titled_findingsasserts"suggestion"is absent from the whole workflow file, not only the prompt. Any later comment or script change inclaude-review.ymlthat uses the word fails the test. Scoping the check to the prompt text would be sturdier.- The suggestion vetting is dormant by design, because the prompt does not ask for suggestions. A prompt-injected answer can still emit one well-formed single-line suggestion, and the script keeps it on the cited line. A reader who clicks Apply should check the replacement text, since the script cannot judge its content.
- The long-run rule replaces any chain of token characters with a run over 128 characters, in finding bodies and the summary as well as
path. A long identifier quoted in a finding, such as a test method name or a base64 blob, is therefore turned into[redacted]. The post then says "credential-shaped string(s) were redacted… most likely sample or placeholder tokens". This is rare and the posted warning is slightly misleading in that case. test_suggestion_handling_takes_linear_time_on_long_input,test_redacting_takes_linear_time_on_long_inputandtest_a_path_past_the_limit_gets_the_full_ruleassert wall-clock bounds of 2–3 seconds. They are generous, but they can flake on a heavily loaded runner. A scaling comparison (time at n versus 2n) would be more robust.first_paragraphinrelease_post.pystill usessplitlines(). It only joins wrapped lines with a space, so a U+2028 there is harmless. It is inconsistent with the other splits changed in this PR.
No findings.
mpaulosky
added a commit
that referenced
this pull request
Oct 26, 2026
Automated release blog posts for #283, #284, opened by the release workflow. It holds every Release whose post isn't on main yet, rebuilt from main on each run. The [skip-release] title marker keeps its merge from starting another release. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Re-Apply the repo-ci-baseline Template so this repo carries the Template changes from mpaulosky/dotfiles#298 and mpaulosky/dotfiles#300.
What changed
726ce26Apply commit,apply.shoutput alone: brings fix(baseline): Split release_post.py's gh api output on newlines only dotfiles#298 and feat(baseline): Ask Claude Review for a structured summary and titled findings with suggestions dotfiles#300..github/scripts/post_claude_review.py.github/scripts/release_post.py.github/scripts/tests/test_post_claude_review.py.github/scripts/tests/test_release_post.py.github/workflows/claude-review.yml.sandcastle/lib/branches.mts.sandcastle/lib/branches.test.mts.sandcastle/lib/build.mts.sandcastle/lib/build.test.mtsVerification
apply.sh's output on a branch up to date withmain.scripts/gate.sh) passed on726ce26.🤖 Generated with Claude Code