Skip to content

chore: Re-apply the repo-ci-baseline Template - #284

Merged
mpaulosky merged 1 commit into
mainfrom
chore/reapply-baseline
Oct 26, 2026
Merged

mpaulosky merged 1 commit into
mainfrom
chore/reapply-baseline

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Why

Re-Apply the repo-ci-baseline Template so this repo carries the Template changes from mpaulosky/dotfiles#298 and mpaulosky/dotfiles#300.

What changed

Verification

  • The Apply commit is exactly apply.sh's output on a branch up to date with main.
  • The pre-push gate (scripts/gate.sh) passed on 726ce26.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test Results Summary

483 tests  ±0   483 ✅ ±0   19s ⏱️ +4s
  9 suites ±0     0 💤 ±0 
  9 files   ±0     0 ❌ ±0 

Results for commit 726ce26. ± Comparison against base commit 06f4015.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.63%. Comparing base (06f4015) to head (726ce26).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files          75       75           
  Lines        1566     1566           
  Branches      186      186           
=======================================
  Hits         1341     1341           
  Misses        190      190           
  Partials       35       35           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpaulosky mpaulosky added the review:claude Claude reviews each head, a backup to Copilot's review label Oct 26, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Review

Overview
This PR makes four changes:

  • The review prompt now asks for a structured Markdown summary (Overview, Changes table, Advisory, Not reviewed) and a bold title on each finding.
  • post_claude_review.py and the matching inline check in the workflow gain a bounded-time credential redaction. They also gain a path rule, which scans file names with CREDENTIAL only and applies the long-run rule only past 1024 characters.
  • post_claude_review.py vets GitHub one-click suggestions: one single-line suggestion on the cited line is kept, anything else becomes a ```text fence. Off-diff findings are indented under their bullet.
  • Smaller fixes: release_post.py stops splitting on U+2028/U+2029, and the Sandcastle headOfRef helper picks the exact refs/heads/<branch> line from ls-remote.

I found nothing that should block the merge. Having traced the regexes, the redaction ordering and the workflow/script mirroring, I believe they behave as the tests claim. I did not run the tests.

Changes

File What changed
.github/workflows/claude-review.yml The prompt asks for a sectioned Markdown summary and titled findings. The inline answer check gains MAX_TOKEN_RUN, TOKEN_CHAIN, redact_credentials and redact_path. redact takes a key so path fields get the path rule.
.github/scripts/post_claude_review.py Adds the same redaction. Adds SUGGESTION_FENCE, ONE_LINE_SUGGESTION, defuse_suggestions, suggestion_line_is_safe and vet_suggestions. Suggestions are defused on the nearest-line and off-diff paths. Off-diff bodies are indented under their bullet.
.github/scripts/release_post.py _list, commit_subject and update_blog_index split on Markdown line endings only, not str.splitlines().
.sandcastle/lib/branches.mts, build.mts New headOfRef picks the exact-ref line. originRefs.remoteHead, remoteMainIs and remoteBranchIsOnOrigin use it. This fixes remoteHead returning the wrong commit when a tail-matching ref sorts first, which would have fed a wrong lease SHA to deleteRemote.
test_post_claude_review.py, test_release_post.py, branches.test.mts, build.test.mts Tests for suggestion vetting, redaction (including linear-time and script/workflow parity checks), Unicode separators and headOfRef.

Advisory (not blocking)

  • test_the_prompt_asks_for_a_structured_summary_and_titled_findings asserts "suggestion" is absent from the whole workflow file, not only the prompt. Any later comment or script change in claude-review.yml that uses the word fails the test. Scoping the check to the prompt text would be sturdier.
  • The suggestion vetting is dormant by design, because the prompt does not ask for suggestions. A prompt-injected answer can still emit one well-formed single-line suggestion, and the script keeps it on the cited line. A reader who clicks Apply should check the replacement text, since the script cannot judge its content.
  • The long-run rule replaces any chain of token characters with a run over 128 characters, in finding bodies and the summary as well as path. A long identifier quoted in a finding, such as a test method name or a base64 blob, is therefore turned into [redacted]. The post then says "credential-shaped string(s) were redacted… most likely sample or placeholder tokens". This is rare and the posted warning is slightly misleading in that case.
  • test_suggestion_handling_takes_linear_time_on_long_input, test_redacting_takes_linear_time_on_long_input and test_a_path_past_the_limit_gets_the_full_rule assert wall-clock bounds of 2–3 seconds. They are generous, but they can flake on a heavily loaded runner. A scaling comparison (time at n versus 2n) would be more robust.
  • first_paragraph in release_post.py still uses splitlines(). It only joins wrapped lines with a space, so a U+2028 there is harmless. It is inconsistent with the other splits changed in this PR.

No findings.

@mpaulosky
mpaulosky merged commit 3746133 into main Oct 26, 2026
36 checks passed
@mpaulosky
mpaulosky deleted the chore/reapply-baseline branch October 26, 2026 17:02
mpaulosky added a commit that referenced this pull request Oct 26, 2026
Automated release blog posts for #283, #284, opened by the release
workflow. It holds every Release whose post isn't on main yet, rebuilt
from main on each run. The [skip-release] title marker keeps its merge
from starting another release.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:claude Claude reviews each head, a backup to Copilot's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant