Skip to content

chore(baseline): Re-apply the repo-ci-baseline Template - #253

Merged
mpaulosky merged 3 commits into
mainfrom
chore/reapply-baseline
Oct 31, 2026
Merged

mpaulosky merged 3 commits into
mainfrom
chore/reapply-baseline

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Summary

Re-applies the repo-ci-baseline Template to TicketManager, bringing mpaulosky/dotfiles#368, mpaulosky/dotfiles#369, mpaulosky/dotfiles#370, mpaulosky/dotfiles#374, mpaulosky/dotfiles#375, mpaulosky/dotfiles#378, mpaulosky/dotfiles#380 and mpaulosky/dotfiles#381.

  • 65 Owned files are byte-identical to the Template's.
  • Seed changes made by hand because Apply never overwrites a Seed file: package.json gains sandcastle:status, .sandcastle/check.sh unsets the GIT_* variables, and .sandcastle/review-prompt.md uses {{PR_BODY_RULES}}.
  • Pinned by .sandcastle/repo-scripts.test.mts.

Local pre-push review: 2 rounds, 2 Critical fixed, 2 Advisory left for a follow-up (the Template's gate.sh runs Docker and Playwright test projects; the sandbox gate's comments say it lints but check.sh does not).

🤖 Generated with Claude Code

mpaulosky and others added 3 commits October 30, 2026 20:32
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The Template's review-prompt.md fills in what the host refuses in the reviewer's PR description from {{PR_BODY_RULES}}; this repo's copy wrote those rules by hand, and lib/config.test.mts fails without the placeholder.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…* unset

Apply never overwrites a Seed file, so the re-Apply left package.json without
the sandcastle:status script that .sandcastle/status.mts documents, and
.sandcastle/check.sh without the unset of the GIT_* variables a git hook sets.
A test pins both.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test Results Summary

98 tests  ±0   98 ✅ ±0   34s ⏱️ +6s
 6 suites ±0    0 💤 ±0 
 6 files   ±0    0 ❌ ±0 

Results for commit cf5530f. ± Comparison against base commit fb098a4.

@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (fb098a4) to head (cf5530f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   90.07%   89.82%   -0.26%     
==========================================
  Files          17       17              
  Lines         393      393              
  Branches       85       85              
==========================================
- Hits          354      353       -1     
  Misses         15       15              
- Partials       24       25       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpaulosky mpaulosky added the review:claude Claude reviews each head, a backup to Copilot's review label Oct 31, 2026
@mpaulosky

Copy link
Copy Markdown
Owner Author

Copilot was asked to review this head (REST and GraphQL review requests) and neither registered a review request, so it cannot review this PR. Recorded by hand because this PR delivers the PR Auto-Merge that would post it.

@mpaulosky mpaulosky added review:claude Claude reviews each head, a backup to Copilot's review and removed review:claude Claude reviews each head, a backup to Copilot's review labels Oct 31, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Review

Overview

This is a repo-ci-baseline Template Apply. It adds:

  • a CI job that checks the PR against the base branch's copy of the gh-repository checker;
  • a Copilot-instructions sync workflow;
  • a Sandcastle workflow with a record-head job;
  • watch-pr.sh, sync-copilot-review.sh and the hardening-review scripts;
  • a large rewrite of PR Auto-Merge (a review loop counted in dirty rounds, Claude as Copilot's backup only, and an exhaustion comment);
  • the matching Claude Review changes.

I found one real inconsistency, in the new "Skip while Copilot can review" step of claude-review.yml. The rest of what I could read looks sound. The tests, the TypeScript Sandcastle code and the docs were not read (see Not reviewed), so this is not a complete review of the PR.

Changes

File What changed
.github/workflows/ci.yml New gh-repo job. It runs the base SHA's check_gh_repo.py over the PR tree and compares the base's Owned files with the head's. Two hook-test steps added.
.github/workflows/claude-review.yml New first step decides whether Copilot can still review, and Claude skips the review while it can. The merge-from-main job can now review a newer head against main's tip. Template-copy dedupe added to the diff splitter.
.github/workflows/copilot-review-sync.yml New workflow running scripts/sync-copilot-review.sh --check.
.github/workflows/pr-automerge.yml labeled trigger added. Review cap replaced by a dirty-round loop with restarts. Copilot is asked once per PR with a recorded ask. Claude is called in only where Copilot can't review. An exhaustion comment is posted.
.github/workflows/sandcastle.yml New Sandcastle host workflow and a record-head job.
.github/scripts/check_gh_repo.py, scripts/gate.sh, scripts/review.sh, .sandcastle/check.sh New checker. The gate runs the checker and the Copilot-instructions sync check. check.sh unsets the GIT_* variables.
scripts/sync-copilot-review.sh, scripts/watch-pr.sh New scripts.
.claude/skills/hardening-review/scripts/*.py New known_open.py and mutate.py.
.sandcastle/lib/branches.mts, .sandcastle/.env.example isHandOffBranch and the SANDCASTLE_MODE note.

Advisory (not blocking)

  • sandcastle.yml, header comment: "Its pull request triggers are pull_request_target" is not true of pull_request_review. That event runs the workflow file from the PR's merge ref, not from main. The job checks out main itself, and a same-repo pusher could already read the secrets with their own workflow, so this adds no escalation. The comment is just inaccurate.
  • scripts/watch-pr.sh:
    • ours() treats any comment, review or thread reply that contains the session marker anywhere, or starts with <!-- sandcastle:x -->, as the owner's. A third party can therefore silence the watcher for their own comment. The person filter excludes only Bot accounts, not people without write access.
    • Conversely, the first 200 characters of any person's comment are printed into the agent session. That is a prompt-injection channel on a public repo. Consider filtering by authorAssociation.
  • pr-automerge.yml, exhausted loop: a head nobody reviewed, with unresolved Copilot or Claude threads, now merges once CI is green. This follows from the documented design (dotfiles#378). It does weaken the merge gate for the PR's own author, so confirm it is intended.
  • pr-automerge.yml, ask record: the ask record is read only from the PR's last 100 comments. If it has scrolled off, copilotAsk returns "unread" and a dropped Copilot request (no quota note) never calls Claude in. The PR waits for a manual merge. This only happens on a PR with more than 100 comments.

Not reviewed

  • Not read: pieces 009–037. These hold the Sandcastle TypeScript sources and their tests (.sandcastle/lib/*.mts, main.mts, status.mts, package.json, *.test.mts), pr-automerge.test.mjs, the Python and shell tests, and the docs.
  • Docs in those pieces: .claude/rules/sandcastle-hand-off.md, the hardening-review and pre-push-review skill docs, .github/ci/sandcastle-skills.txt, .sandcastle/review-prompt.md, .security/README.md and docs/PROCESS.md.
  • In 014: .github/hooks/tests/pre-push.test.sh.
  • .gitignore was excluded and is held for a person.
  • claude-review.yml and pr-automerge.yml were not in the context pieces. I judged them from the diff and could not re-read the checked-out files. The finding's line number comes from counting lines in the diff hunk, not from a read of the file.

Findings outside the diff (no thread to resolve, so they hold the merge until the next push gets a fresh review):

  • diff:0: Claude Review didn't read all of diff pieces 009.diff, 010.diff, 011.diff, 012.diff, 013.diff, 014.diff, 015.diff, 016.diff, 017.diff, 018.diff, 019.diff, 020.diff, 021.diff, 022.diff, 023.diff, 024.diff, 025.diff, 026.diff, 027.diff, 028.diff, 029.diff, 030.diff, 031.diff, 032.diff, 033.diff, 034.diff, 035.diff, 036.diff, 037.diff: they're past what one review reads, or a Read of them failed or came back in part. The log of the review job's "Check Claude's answer for secrets" step lists their files. Review those files yourself, then merge by hand.
  • diff:0: Claude Review didn't read 1 changed file(s): files Copilot code review excludes (such as dist, bin, vendor or generated files, build configs or lockfiles), files the diff shows only as binary, submodule bumps, symlinks or Git LFS pointers. The log of the review job's "Check Claude's answer for secrets" step lists them. Review them yourself, then merge by hand.

Comment thread .github/workflows/claude-review.yml Resolved
@mpaulosky
mpaulosky merged commit 4e27945 into main Oct 31, 2026
42 checks passed
@mpaulosky
mpaulosky deleted the chore/reapply-baseline branch October 31, 2026 05:53
mpaulosky added a commit that referenced this pull request Oct 31, 2026
Automated release blog posts for #253, opened by the release workflow.
It holds every Release whose post isn't on main yet, rebuilt from main
on each run. The [skip-release] title marker keeps its merge from
starting another release.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:claude Claude reviews each head, a backup to Copilot's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants