Skip to content

chore: Re-apply the repo-ci-baseline Template - #263

Merged
mpaulosky merged 3 commits into
mainfrom
chore/reapply-baseline
Nov 10, 2026
Merged

mpaulosky merged 3 commits into
mainfrom
chore/reapply-baseline

Conversation

@mpaulosky

@mpaulosky mpaulosky commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Why

Re-Apply the repo-ci-baseline Template so this repo carries the Template changes from mpaulosky/Application_Factory#36, mpaulosky/Application_Factory#37, mpaulosky/Application_Factory#38 and mpaulosky/Application_Factory#39.

What changed

Verification

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 19:11
@mpaulosky

Copy link
Copy Markdown
Owner Author

Copilot's review was requested for this PR. It is asked once per PR; if GitHub drops the request, review:claude calls in Claude instead. mpaulosky/dotfiles#360

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The skills-list documentation still directs operators to pin the wrong repository and use an outdated skills path, causing skill setup to fail when followed.

1 open issue
What changed in this PR

Reapplies the repo-ci-baseline template updates to the repository’s CI workflows, Sandcastle automation, and branch policies.

Changes:

  • Restricts published reviewer logs to bounded, fixed-message summaries and moves skill installation to Application Factory.
  • Tightens Copilot bot identification and delays Claude fallback until the review-request record has settled.
  • Allows pushes to Dependabot branches while excluding them from Sandcastle hand-offs, and removes LICENSE from template-owned paths.
File Description
scripts/​tests/​check-branch-name.test.sh Tests allowed and rejected Dependabot branch names.
scripts/​check-branch-name.sh Allows shell-safe Dependabot branches for pushes.
.sandcastle/​lib/​role-logs.test.mts Tests fixed-message summaries, secret filtering, and log limits.
.sandcastle/​lib/​role-logs.mts Publishes bounded summaries only for known build logs.
.sandcastle/​lib/​review-ledger.test.mts Verifies that LICENSE is not template-owned.
.sandcastle/​lib/​review-ledger.mts Removes LICENSE from template-owned paths.
.sandcastle/​lib/​branches.test.mts Accounts for Dependabot’s exclusion from hand-offs.
.sandcastle/​lib/​branches.mts Clarifies the existing hand-off restriction in a comment.
.github/​workflows/​sandcastle.yml Installs skills from Application Factory and documents log sanitization.
.github/​workflows/​pr-automerge.yml Tightens bot matching and waits before Claude fallback.
.github/​workflows/​lint-actions.yml Updates the pinned zizmor action to v0.8.1.
.github/​scripts/​tests/​pr-automerge.test.mjs Adds bot-identity and fallback-timing regression coverage.
.claude/​rules/​sandcastle-hand-off.md Documents that Dependabot branches cannot be handed off.

Review effort: Balanced

Comment thread .github/workflows/sandcastle.yml Resolved
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Test Results Summary

98 tests   98 ✅  30s ⏱️
 6 suites   0 💤
 6 files     0 ❌

Results for commit 427f43e.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (7ebdf0b) to head (427f43e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files          17       17           
  Lines         393      393           
  Branches       85       85           
=======================================
  Hits          353      353           
  Misses         15       15           
  Partials       25       25           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The re-Applied sandcastle.yml reads pinned skills from the Factory's main, not dotfiles.
Comment lines only: the file still lists no pin and no skills.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mpaulosky added a commit to mpaulosky/Application_Factory that referenced this pull request Nov 10, 2026
Fixes R11 from the pre-push review of mpaulosky/TicketManager#263 (see
#40).

#37 made the Branch name check accept only `A-Za-z0-9._-` in a
`dependabot/*` name, in both forms. The `--pr` form accepted any
`dependabot/*` before, so a Dependabot PR whose branch carries another
character (a scoped npm package's `@`, a version's `+`) would fail the
required `Branch name` check. All 146 real Dependabot branch names in
the Fleet match the pattern, but none is an ungrouped scoped npm
package, so the data neither confirms nor rules it out.

- `--pr` takes any `dependabot/*` again, as before #37; CI quotes the
name.
- The hook form stays shell-safe and now also takes `@` and `+`.
- Tests: `@` and `+` in the first and later segments, `--pr` leniency,
and refused `dependabot/`, `dependabot/a/`, `dependabot//a`,
`Dependabot/x`, `claude/dependabot/x`, `xdependabot/a` and a name with a
newline. Five mutations (`+` to `*` in each segment, dropping `@`/`+`,
dropping the `--pr` branch, unanchoring) each fail a test.
- `references/git-hooks.md` updated. `scripts/check-branch-name.sh`
copied over; `scripts/gate.sh` and the Sandcastle check pass.

Left in #40: R3-R9, R19 and the rest.

Rollout: `scripts/check-branch-name.sh` and its test are Owned files, so
this reaches the Fleet by a Rollout. TicketManager's re-Apply (#263) is
waiting for it.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
mpaulosky added a commit to mpaulosky/Application_Factory that referenced this pull request Nov 10, 2026
…ry path (#42)

Fixes R1, the Critical from the pre-push review of
mpaulosky/TicketManager#263 (see #40).

`askCopilotOnce` waited out the rest of `COPILOT_ASK_SETTLE_MS` (#23)
only when the Copilot review request failed. Two other paths returned
`true` about one poll after the request, with the ask record seconds
old: the read-back's `catch`, and the `break` when the head moved. The
caller then added `review:claude`; Claude Review skips a record younger
than 30 s and a later PR Auto-Merge run strips the label, so Claude's
review waited for another event or sweep.

- One local `waitOutSettle()` (the same wait: the rest of the window,
capped by `COPILOT_ASK_WAIT_MS`) is called on all three paths. A
registered request needs none, and an unregistered one already waited
the whole read-back window.
- Tests on the mock clock: the read-back error and the moved head each
hold the run, and `review:claude`, until the record is 30 s old; a
registered request ends the run early. Both new tests fail without the
fix. The existing failed-request test now has an upper bound, so
removing the `COPILOT_ASK_WAIT_MS` cap fails it (the run took 30 s);
this is R6's missing bound. A record already older than the window is
still untested.
- The header no longer says a failed request counts as dropped "at once"
(R4).
- The Factory's copy of `pr-automerge.yml` is copied over.
`scripts/gate.sh` passes.

Still in #40: R3, R5, R6 (the older-record case), R7, R8, R9, R19.

Rollout: `pr-automerge.yml` and its test are Owned files, so this
reaches the Fleet by a Rollout. TicketManager's re-Apply (#263) is
waiting for it and then gets one review run covering both Template
fixes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 20:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Maintainer confirmation is needed that the intentionally retained channel in public reviewer-log artifacts (~72 selectable bits per log, up to 20 logs) is acceptable under the sandbox credential threat model.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@mpaulosky
mpaulosky merged commit c8cc1a5 into main Nov 10, 2026
38 of 39 checks passed
@mpaulosky
mpaulosky deleted the chore/reapply-baseline branch November 10, 2026 20:54
mpaulosky added a commit that referenced this pull request Nov 10, 2026
Automated release blog posts for #263, opened by the release workflow.
It holds every Release whose post isn't on main yet, rebuilt from main
on each run. The [skip-release] title marker keeps its merge from
starting another release.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants