Repository navigation
chore: Re-apply the repo-ci-baseline Template - #266
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
Copilot's review was requested for this PR. It is asked once per PR; if GitHub drops the request, review:claude calls in Claude instead. mpaulosky/dotfiles#360 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 17 17
Lines 393 393
Branches 85 85
=======================================
Hits 353 353
Misses 15 15
Partials 25 25 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Stale-lock recovery can permit concurrent ledger writes that lose updates or reuse finding IDs, while the publication fallback can allow text exceeding the combining-mark limit.
2 open issues
What changed in this PR
Re-applies the repo-ci-baseline template from Application Factory #43, updating Sandcastle’s review safety, record handling, and pre-push enforcement.
Changes:
- Strengthens text sanitization, secret checks, and filtering of links in public review output.
- Adds atomic record replacement, entry-creation retries, and stale-lock recovery.
- Prevents pushes from skipping gate self-tests and makes review guidance portable across repositories.
| File | Description |
|---|---|
.sandcastle/lib/security-record.test.mts |
Tests heading safety, atomic writes, collisions, and write failures. |
.sandcastle/lib/security-record.mts |
Improves entry creation, replacement, and output sanitization. |
.sandcastle/lib/review-ledger.test.mts |
Tests lock recovery, sanitized findings, and public notes. |
.sandcastle/lib/review-ledger.mts |
Updates locking, persistence, validation, and output filtering. |
.sandcastle/lib/pre-push-review-skill.test.mts |
Adjusts the mutation-runner reference assertion. |
.sandcastle/lib/plain-text.test.mts |
Tests Unicode sanitization and link detection. |
.sandcastle/lib/plain-text.mts |
Adds shared sanitization and link-detection helpers. |
.sandcastle/lib/host-review.test.mts |
Tests sanitized reviewer fields and branch-link filtering. |
.sandcastle/lib/host-review.mts |
Shares finding validation and tightens public issue filtering. |
.sandcastle/lib/critique.test.mts |
Tests withholding secrets split by invisible characters. |
.sandcastle/lib/build.test.mts |
Tests secret checks across normalized text forms. |
.sandcastle/lib/build.mts |
Checks public error text before and after normalization. |
.github/hooks/tests/pre-push.test.sh |
Tests removal of the self-test bypass during pushes. |
.github/hooks/pre-push |
Clears review and self-test bypass variables. |
.claude/skills/pre-push-review/SKILL.md |
Makes guidance conditional on repository capabilities and updates template ownership. |
Review effort: Balanced
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mpaulosky
added a commit
that referenced
this pull request
Nov 11, 2026
Automated release blog posts for #266, opened by the release workflow. It holds every Release whose post isn't on main yet, rebuilt from main on each run. The [skip-release] title marker keeps its merge from starting another release. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why
Re-Apply the repo-ci-baseline Template so this repo carries the Template changes from mpaulosky/Application_Factory#43.
What changed
afafa65Apply commit,apply.shoutput alone: brings feat(factory): Carry the local pre-push review and require it in the gate Application_Factory#43..claude/skills/pre-push-review/SKILL.md.github/hooks/pre-push.github/hooks/tests/pre-push.test.sh.sandcastle/lib/build.mts.sandcastle/lib/build.test.mts.sandcastle/lib/critique.test.mts.sandcastle/lib/host-review.mts.sandcastle/lib/host-review.test.mts.sandcastle/lib/plain-text.mts.sandcastle/lib/plain-text.test.mts.sandcastle/lib/pre-push-review-skill.test.mts.sandcastle/lib/review-ledger.mts.sandcastle/lib/review-ledger.test.mts.sandcastle/lib/security-record.mts.sandcastle/lib/security-record.test.mtsVerification
The Apply commit is exactly
apply.sh's output on a branch up to date withmain.The pre-push gate (
scripts/gate.sh) passed onafafa65.7c7cf86Apply commit,apply.shoutput alone: brings feat(factory): Carry the local pre-push review and require it in the gate Application_Factory#43 and fix(baseline): Cap combining marks in publicErrorText so hidden text is not published Application_Factory#45.a9d1973Apply commit,apply.shoutput alone: brings feat(factory): Carry the local pre-push review and require it in the gate Application_Factory#43, fix(baseline): Cap combining marks in publicErrorText so hidden text is not published Application_Factory#45 and fix(baseline): Find a GitHub token that text cleaning has run up against a word Application_Factory#46.🤖 Generated with Claude Code