Skip to content

chore: Re-apply the repo-ci-baseline Template - #266

Merged
mpaulosky merged 3 commits into
mainfrom
chore/reapply-baseline
Nov 11, 2026
Merged

mpaulosky merged 3 commits into
mainfrom
chore/reapply-baseline

Conversation

@mpaulosky

@mpaulosky mpaulosky commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Why

Re-Apply the repo-ci-baseline Template so this repo carries the Template changes from mpaulosky/Application_Factory#43.

What changed

  • afafa65 Apply commit, apply.sh output alone: brings feat(factory): Carry the local pre-push review and require it in the gate Application_Factory#43.
    • .claude/skills/pre-push-review/SKILL.md
    • .github/hooks/pre-push
    • .github/hooks/tests/pre-push.test.sh
    • .sandcastle/lib/build.mts
    • .sandcastle/lib/build.test.mts
    • .sandcastle/lib/critique.test.mts
    • .sandcastle/lib/host-review.mts
    • .sandcastle/lib/host-review.test.mts
    • .sandcastle/lib/plain-text.mts
    • .sandcastle/lib/plain-text.test.mts
    • .sandcastle/lib/pre-push-review-skill.test.mts
    • .sandcastle/lib/review-ledger.mts
    • .sandcastle/lib/review-ledger.test.mts
    • .sandcastle/lib/security-record.mts
    • .sandcastle/lib/security-record.test.mts

Verification

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 11, 2026 05:15
@mpaulosky

Copy link
Copy Markdown
Owner Author

Copilot's review was requested for this PR. It is asked once per PR; if GitHub drops the request, review:claude calls in Claude instead. mpaulosky/dotfiles#360

@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (7a4c19b) to head (a9d1973).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files          17       17           
  Lines         393      393           
  Branches       85       85           
=======================================
  Hits          353      353           
  Misses         15       15           
  Partials       25       25           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Test Results Summary

98 tests  ±0   98 ✅ ±0   30s ⏱️ ±0s
 6 suites ±0    0 💤 ±0 
 6 files   ±0    0 ❌ ±0 

Results for commit a9d1973. ± Comparison against base commit 7a4c19b.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Stale-lock recovery can permit concurrent ledger writes that lose updates or reuse finding IDs, while the publication fallback can allow text exceeding the combining-mark limit.

2 open issues
What changed in this PR

Re-applies the repo-ci-baseline template from Application Factory #43, updating Sandcastle’s review safety, record handling, and pre-push enforcement.

Changes:

  • Strengthens text sanitization, secret checks, and filtering of links in public review output.
  • Adds atomic record replacement, entry-creation retries, and stale-lock recovery.
  • Prevents pushes from skipping gate self-tests and makes review guidance portable across repositories.
File Description
.sandcastle/​lib/​security-record.test.mts Tests heading safety, atomic writes, collisions, and write failures.
.sandcastle/​lib/​security-record.mts Improves entry creation, replacement, and output sanitization.
.sandcastle/​lib/​review-ledger.test.mts Tests lock recovery, sanitized findings, and public notes.
.sandcastle/​lib/​review-ledger.mts Updates locking, persistence, validation, and output filtering.
.sandcastle/​lib/​pre-push-review-skill.test.mts Adjusts the mutation-runner reference assertion.
.sandcastle/​lib/​plain-text.test.mts Tests Unicode sanitization and link detection.
.sandcastle/​lib/​plain-text.mts Adds shared sanitization and link-detection helpers.
.sandcastle/​lib/​host-review.test.mts Tests sanitized reviewer fields and branch-link filtering.
.sandcastle/​lib/​host-review.mts Shares finding validation and tightens public issue filtering.
.sandcastle/​lib/​critique.test.mts Tests withholding secrets split by invisible characters.
.sandcastle/​lib/​build.test.mts Tests secret checks across normalized text forms.
.sandcastle/​lib/​build.mts Checks public error text before and after normalization.
.github/​hooks/​tests/​pre-push.test.sh Tests removal of the self-test bypass during pushes.
.github/​hooks/​pre-push Clears review and self-test bypass variables.
.claude/​skills/​pre-push-review/​SKILL.md Makes guidance conditional on repository capabilities and updates template ownership.

Review effort: Balanced

Comment thread .sandcastle/lib/review-ledger.mts Resolved
Comment thread .sandcastle/lib/build.mts Resolved
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 11, 2026 05:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Normalization can bypass publication-time secret detection, allowing complete tokens to leak through advisory summaries and similarly transformed ledger fields.

1 open issue
2 resolved since last review

Review effort: Balanced

Comment thread .sandcastle/lib/host-review.mts Resolved
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 11, 2026 06:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the CI baseline updates to review safety, record handling, and pre-push enforcement.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@mpaulosky
mpaulosky merged commit 9abf76b into main Nov 11, 2026
57 of 58 checks passed
@mpaulosky
mpaulosky deleted the chore/reapply-baseline branch November 11, 2026 08:06
mpaulosky added a commit that referenced this pull request Nov 11, 2026
Automated release blog posts for #266, opened by the release workflow.
It holds every Release whose post isn't on main yet, rebuilt from main
on each run. The [skip-release] title marker keeps its merge from
starting another release.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants