This repository was archived by the owner on Nov 9, 2026. It is now read-only.
Repository navigation
fix(baseline): Let the Owned Sandcastle tests follow the repo's gate command - #285
Merged
Merged
Conversation
…command The tests named scripts/gate.sh, so a repo that sets GATE_COMMAND failed 16 of them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only changes support configured gate paths, keep the Template copies synchronized, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
This follow-up to #284 updates Sandcastle’s Owned tests to support repository-specific GATE_COMMAND values, keeping the baseline Template and dotfiles’ copies synchronized.
Changes:
- Normalize configured gate commands in test doubles so existing command assertions remain valid.
- Create the fake gate script at the configured path, including parent directories.
- Check the configured command in the red-gate summary assertion.
| File | Description |
|---|---|
Support For New Projects/.claude/skills/repo-ci-baseline/template/owned/.sandcastle/lib/git-sandbox-fake.mts |
Creates the fake gate at the configured path. |
Support For New Projects/.claude/skills/repo-ci-baseline/template/owned/.sandcastle/lib/follow-up-pass.test.mts |
Normalizes gate calls and updates the summary assertion. |
Support For New Projects/.claude/skills/repo-ci-baseline/template/owned/.sandcastle/lib/checkpoint.test.mts |
Normalizes gate calls in checkpoint tests. |
Support For New Projects/.claude/skills/repo-ci-baseline/template/owned/.sandcastle/lib/build.test.mts |
Normalizes gate calls in build tests. |
.sandcastle/lib/git-sandbox-fake.mts |
Mirrors the Template’s configured fake gate path. |
.sandcastle/lib/follow-up-pass.test.mts |
Mirrors the Template’s follow-up test changes. |
.sandcastle/lib/checkpoint.test.mts |
Mirrors the Template’s checkpoint test changes. |
.sandcastle/lib/build.test.mts |
Mirrors the Template’s build test changes. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #284.
GATE_COMMANDmade the gate command repo-configurable, but the Owned tests still namedscripts/gate.sh, so a repo that sets it (the four Sandcastle migrations set.sandcastle/check.sh) failed 16 of them.build.test.mts,checkpoint.test.mtsandfollow-up-pass.test.mts: the fake sandbox reports the configured command as the Template's default, so the expected command lists stay as they are.git-sandbox-fake.mts: writes its gate script atGATE_COMMAND's path.follow-up-pass.test.mts: the red-gate message test checks the configured command.scripts/gate.shpasses here. WithGATE_COMMANDset to.sandcastle/check.sh,pnpm run check:sandcastlepasses in Articles, IssueManager, IssueTracker and TicketManager.