Skip to content
This repository was archived by the owner on Nov 9, 2026. It is now read-only.

fix(baseline): Let the Owned Sandcastle tests follow the repo's gate command - #285

Merged
mpaulosky merged 1 commit into
mainfrom
chore/sandcastle-gate-command-tests
Oct 25, 2026
Merged

mpaulosky merged 1 commit into
mainfrom
chore/sandcastle-gate-command-tests

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Follow-up to #284. GATE_COMMAND made the gate command repo-configurable, but the Owned tests still named scripts/gate.sh, so a repo that sets it (the four Sandcastle migrations set .sandcastle/check.sh) failed 16 of them.

  • build.test.mts, checkpoint.test.mts and follow-up-pass.test.mts: the fake sandbox reports the configured command as the Template's default, so the expected command lists stay as they are.
  • git-sandbox-fake.mts: writes its gate script at GATE_COMMAND's path.
  • follow-up-pass.test.mts: the red-gate message test checks the configured command.

scripts/gate.sh passes here. With GATE_COMMAND set to .sandcastle/check.sh, pnpm run check:sandcastle passes in Articles, IssueManager, IssueTracker and TicketManager.

…command

The tests named scripts/gate.sh, so a repo that sets GATE_COMMAND failed 16 of them.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 25, 2026 21:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused test-only changes support configured gate paths, keep the Template copies synchronized, and have no identified blocking issues.

No open issues 🎉

What changed in this PR

This follow-up to #284 updates Sandcastle’s Owned tests to support repository-specific GATE_COMMAND values, keeping the baseline Template and dotfiles’ copies synchronized.

Changes:

  • Normalize configured gate commands in test doubles so existing command assertions remain valid.
  • Create the fake gate script at the configured path, including parent directories.
  • Check the configured command in the red-gate summary assertion.
File Description
Support For New Projects/​.claude/​skills/​repo-ci-baseline/​template/​owned/​.sandcastle/​lib/​git-sandbox-fake.mts Creates the fake gate at the configured path.
Support For New Projects/​.claude/​skills/​repo-ci-baseline/​template/​owned/​.sandcastle/​lib/​follow-up-pass.test.mts Normalizes gate calls and updates the summary assertion.
Support For New Projects/​.claude/​skills/​repo-ci-baseline/​template/​owned/​.sandcastle/​lib/​checkpoint.test.mts Normalizes gate calls in checkpoint tests.
Support For New Projects/​.claude/​skills/​repo-ci-baseline/​template/​owned/​.sandcastle/​lib/​build.test.mts Normalizes gate calls in build tests.
.sandcastle/​lib/​git-sandbox-fake.mts Mirrors the Template’s configured fake gate path.
.sandcastle/​lib/​follow-up-pass.test.mts Mirrors the Template’s follow-up test changes.
.sandcastle/​lib/​checkpoint.test.mts Mirrors the Template’s checkpoint test changes.
.sandcastle/​lib/​build.test.mts Mirrors the Template’s build test changes.

Review effort: Balanced

@mpaulosky
mpaulosky merged commit a751396 into main Oct 25, 2026
3 checks passed
@mpaulosky
mpaulosky deleted the chore/sandcastle-gate-command-tests branch October 25, 2026 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants