Repository navigation
Let the wheel scroll inner scroll containers in comment mode - #16
Merged
Merged
Conversation
The fixed selection cover received every wheel event, so the browser only scrolled its ancestors (the document). Pages that scroll inside an element, such as an app shell under a body with hidden overflow or a scrolling table, could not be scrolled while commenting. The wheel is now handed to the nearest element under the pointer that can still scroll in that direction, and the top document keeps its native scrolling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
html, body { overflow: hidden }froze completely, and a scrolling table under the pointer stayed still while the document moved instead. This was reported on a React project, but the cause is the layout (CSS), not React.docs/architecture.mddescribes the behaviour.Checks
demo/react.html) before the fix: with#rootas the scroll container, the wheel moved nothing in comment mode (it scrolled 500 px outside comment mode); over the accounts table, the table stayed at 0 and the document scrolled.#rootscrolls, the table scrolls to its end, and clicking a cell after scrolling selects that cell.the wheel in comment mode scrolls a page whose content scrolls inside an app shell instead of the document(@cross-engine) failed in Chromium and WebKit before the fix and passes after it.pnpm typecheck,pnpm test(512 passed),pnpm build,pnpm test:e2e(297 passed).Notes
touch-action: noneso touch drags select an area.🤖 Generated with Claude Code