Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MXSwipe now describes its menu to MenuHub instead of owning a status item. On its own the menu is unchanged. With RetinaShot also running, the two share one icon, and its menu has a section per app.
main.swiftbuilds aMenuSection(the mouse header plus items) in place of the NSStatusItem, NSMenu, icon, and header code, which moved into MenuHub.Tools/make-readme-assets.swiftnow lays out the README images with MenuHub's own code, and CI type-checks it. The images are re-rendered: the header now starts at the checkmark column.Tested locally with RetinaShot: the icon handoff when either app quits or relaunches, clicks routed to the app that described the item, and light and dark renders. 71 tests pass.