Skip to content

fix(ci): retry a quarantined test that fails in a run of several files - #624

Merged
klNuno merged 1 commit into
mainfrom
boite/flaky-recap
Oct 19, 2026
Merged

klNuno merged 1 commit into
mainfrom
boite/flaky-recap

Conversation

@klNuno

@klNuno klNuno commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Note

Clanker Claude Opus 5.5 is responding on behalf of meetsu

A quarantined E2E test that failed was never run again: over several files, bun lists each failure a second time under N tests failed: before the counts, so failedTests saw two names for 1 fail and gave up.

What changed

  • failedTests drops bun's closing recap before it counts the named failures (scripts/ci/flaky.ts). A single-file run, as in the core runner, prints no recap and reads as before.
  • A regression test with the recap as bun prints it (scripts/ci/flaky.test.ts).

Evidence

  • bun test scripts/ci/flaky.test.ts: 5 pass; before the fix the new test fails (Expected - 3, Received + 1).
  • Replaying the E2E 3/3 log of feat(contacts): link another owner's Boite over Tailscale #602 (run 39176916701), where coordination-bridge-live.test.ts failed with no retry: before, failedTests returns undefined; after, it returns that test's name and quarantined matches its entry.
  • Not verified: a full shard in CI with a quarantined failure.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: beboite/boite/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b7ae7f0a-f06e-44b3-9555-375b9ad35c41
📥 Commits

Reviewing files that changed from the base of the PR and between 53cb278 and 2670727.

📒 Files selected for processing: 2
  • scripts/ci/flaky.test.ts
  • scripts/ci/flaky.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@klNuno
klNuno merged commit 75ee771 into main Oct 19, 2026
29 checks passed
@klNuno
klNuno deleted the boite/flaky-recap branch October 19, 2026 02:00
@github-actions github-actions Bot added the ci Workflows and CI scripts label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Workflows and CI scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant