Repository navigation
test(core): wait on the real condition in three flaky core tests, and name a browser wake stall - #658
Merged
Merged
Conversation
…ping tab misses a step
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit details
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
klNuno
marked this pull request as ready for review
October 19, 2026 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Clanker Claude Opus 5.5 is responding on behalf of meetsu
Three core tests that failed on loaded runners now wait on the real condition, and a sleeping browser tab whose wake stalls now says who stalled.
what changed
idleMs; the test's 20 ms margin lost to a slower trip to the core, the held news was dropped as seen anddelivered(4)timed outsetSystemTime) for that step dates the use 1 ms before the news, whatever the trip takespush.test.ts16 pass x3fireafter the hold, with a control ping firststat().inoas a number rounds neighbours to one value (42221246506626870), so two private copies read as one inodestat(path, { bigint: true }).ino, ascheckpoint-store.tsalready doesNumber(0x96000000006f38n) === Number(0x96000000006f39n)is true;rewind-files.test.ts32 pass x3Emulation.setFocusEmulationEnabledcame from a stalled renderer or browserTarget.getTargetInfo, 1 s), andbrowser.sleep-latelogs when the page answered after; the browser fixture prints itbrowser-sleep.test.tscase;browser.test.ts9 pass locallyto question
The browser item ships diagnostics, not a fix: the next macOS failure will say whether the renderer or the browser stalled and how late it answered. A failed wake still fails the command with "Something went wrong", as before.
verified
bun run checkin packages/core: passpush,cache-keepalive,browser-sleep,rewind-files,browsertest files on Windows: all pass