[klNuno]

Note

Clanker Claude Opus 5.5 is responding on behalf of meetsu

Main fails two repository checks since #602: packages/core/src/group.ts is 905 lines, above the 900-line ceiling, and the contact link opens its socket with Bun's own WebSocket client, which product-sockets.test.ts forbids. This brings main back under both.

what changed

• The sealed join request and the check of its answer move from GroupStore to packages/core/src/group/join.ts, unchanged; group.ts is 880 lines.
• group.ts re-exports the join route, so server.ts imports it as before.
• The test that held a join behind a slow network now holds the inviting member's answer instead of patching the removed private method (group-devices.test.ts).
• A guest's link to its host dials through TextSocket with the hello in the upgrade headers, as the relay and the client do; a failed or closed link backs off as before (contacts/store.ts).

verified

• bun run check passes, its architecture step included: no source above 900 lines.
• bun test on product-sockets, contacts and the three group suites: 72 pass.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: beboite/boite/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: bcaccf95-fae3-4aa4-bd8f-937be52a45f2

📥 Commits

Reviewing files that changed from the base of the PR and between 0353c0c and 54ffd64.

📒 Files selected for processing: 4

• packages/core/src/contacts/store.ts
• packages/core/src/group.ts
• packages/core/src/group/join.ts
• packages/core/test/group-devices.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}