Repository navigation
fix(phone): give the phone its Experiments row back, so it can show Bots - #791
Merged
Merged
Conversation
Experiments are kept per device, and #601 took the phone's Experiments row out of its settings list. Bots switched on on the computer then left the phone's bottom bar without its Bots tab, with no way to turn it on there. docs/experiments.md still promised the row.
github-actions
Bot
added
documentation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![mtsu-patrol[bot]](https://avatars.githubusercontent.com/in/4979469?s=60&v=4){kind=small}
|
This puts an Experiments row back in the phone settings list so the phone can switch on Bots for itself. Experiments are kept per device, so turning Bots on for the computer had left the phone without its Bots tab and no way to get it. No comments posted: the reviewers raised no finding. Review details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiments are kept per device (
boite.experimentsin each app's storage). #601 removed the phone's Experiments row from its settings list, so Bots enabled on the computer left the phone's bottom bar without its Bots tab, and the phone had no way to turn it on.docs/experiments.mdstill promised the row.MobileSettings.svelte: an Experiments row under This phone, after Privacy.docs/phone.md: experiments move from the desktop-only list to the phone list.MobileSettings.test.tsopens the row, switches Bots on and expects themobile-agentstab; the e2e row lists inmobile.test.tsinclude the row;whip.test.tscomments updated.Checks (2026-10-25):
bun run checkpassed;vitest MobileSettings.test.ts3/3;bun test tests/e2e/mobile.test.ts -t "phone settings expose"1/1;bun test tests/e2e/whip.test.ts3/3.Phone captures at 390x844 on the fake core: the settings list with the row, the Bots tab after the switch, and the Bots list with a bot's face.