Skip to content

fix(cli): honor --pose when --glb/--colmap is present #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aglanio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): honor --pose when --glb/--colmap is present #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions examples/cli/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,13 @@ static int cmd_depth_export(const da::cli::Parsed& p, da::Engine& eng){
std::fprintf(stderr, "error: write_colmap failed\n"); return 1; }
std::printf("wrote COLMAP model (%s) to %s\n", p.colmap_binary ? "bin" : "txt", p.output_colmap.c_str());
}
// Pose is already computed for the glb/colmap export above; honor --pose here
// too (previously silently dropped when --glb/--colmap were present).
if (!p.output_pose.empty()){
if (!da::write_pose_json(p.output_pose, ext, intr)){
std::fprintf(stderr, "error: write pose json failed\n"); return 1; }
std::printf("wrote %s\n", p.output_pose.c_str());
}
if (!p.output_pfm.empty()) da::write_pfm(p.output_pfm, depth, H, W);
if (!p.output_png.empty()) da::write_depth_png(p.output_png, depth, H, W, p.invert);
return 0;
Expand Down