Skip to content

feat(lint): enforce single-word Multigres component names - #69

Merged
GuptaManan100 merged 1 commit into
mainfrom
fix-linting
Jul 5, 2026
Merged

GuptaManan100 merged 1 commit into
mainfrom
fix-linting

Conversation

@GuptaManan100

Copy link
Copy Markdown
Contributor

Summary

  • Rename the miswritten camel-cased component names (MultiPooler, MultiOrch, MultiGateway, MultiAdmin) to their single-word forms Multipooler / Multiorch / Multigateway / Multiadmin — only the leading M is capitalized. Applied across docs, blog posts, the homepage, and the architecture diagram SVGs.
  • Add a CI linter (tools/naming_linter.sh + a lint:naming npm script + a Naming Lint job) that rejects the camel-cased forms so the inconsistency can't creep back in.

Description

Mirrors multigres/multigres#1237, which did the same rename and added a git grep-based linter on the backend. The component names are single words, so only the first letter should be capitalized; the site had 171 occurrences of the PascalCase forms (including plurals like MultiGateways) across content and the diagram <text> labels.

The linter is a git grep for [Mm]ulti(Pooler|Orch|Gateway|Gres|Admin), which flags the PascalCase and camelCase forms while leaving the correct single-word forms and the SCREAMING_CASE constant form (e.g. ID_MULTIPOOLER) untouched. It excludes itself (it necessarily spells out the forbidden forms) and relies on git grep skipping the gitignored node_modules/build/.source trees.

Adapted for this pnpm/Node repo: the check is wired as a lint:naming npm script and a new .github/workflows/lint.yml Naming Lint job (the repo had no workflows before) rather than a Makefile target. Coverage also extends to the diagram SVGs, since those are the source of truth for the architecture images here.

@vercel

vercel Bot commented Jul 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
multigres-site Ready Ready Preview, Comment Jul 4, 2026 9:40am

Request Review

@GuptaManan100
GuptaManan100 marked this pull request as ready for review July 4, 2026 09:37
Multigateway, Multipooler, Multiorch, Multiadmin (and Multigres itself)
are single words — only the leading M is capitalized. Content, the
homepage, and the architecture diagram SVGs had camel-cased forms like
MultiPooler/MultiGateway; rename them all to the single-word forms.

Add tools/naming_linter.sh (a git grep for the forbidden PascalCase and
camelCase forms), a lint:naming npm script, and a Naming Lint CI job so
the inconsistency can't creep back in.

Signed-off-by: GuptaManan100 <guptamanan100@gmail.com>

@Verolop Verolop left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@GuptaManan100
GuptaManan100 merged commit 89c9a19 into main Jul 5, 2026
4 checks passed
@GuptaManan100
GuptaManan100 deleted the fix-linting branch July 5, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants