fix: drop ua-based markdown switching - #71
Merged
Merged
Conversation
Signed-off-by: Pamela Chia <pamelachiamayyee@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The middleware served markdown based on user-agent matching, but markdown responses only declare
Vary: Accept, so the CDN cache key ignores the user agent and whichever variant is computed first gets cached for every client. I observed this live as deterministic variant poisoning: byte-identicalChatGPT-Userrequests receivedtext/htmlon GET andtext/markdownon HEAD for the same cached URL. This change removes the UA branch so content varies only by theAcceptheader, which makes the declaredVarytruthful and the poisoning structurally impossible. Clients that want markdown still get it viaAcceptnegotiation or explicit.mdURLs; separately, theChatGPT-Useragent's reader currently hard-fails on markdown it receives via UA matching (details in GROWTH-973), so consistently serving it the fully server-rendered HTML also fixes readability in that assistant.Changes
LIVE_FETCH_UA_RE/isLiveFetchAgentfromsrc/start.ts; bare URLs serve markdown only when theAcceptheader prefers it, explicit.mdURLs unchangedTesting
Tested locally:
ChatGPT-UserandClaude-UserUA GETs returntext/html;Accept: text/markdownreturnstext/markdown; GET and HEAD agreeAccept: text/markdown, text/html, */*, which wins negotiation)Verify in production post-deploy (dev harness cannot exercise these):
.mdURLs still serve markdownLinear