Muscle manager: check timelines - #412
Merged
Merged
Conversation
TODO: work on timelines for muscle3_tester components
IrisvdWerf
reviewed
Sep 3, 2026
LourensVeen
approved these changes
Sep 8, 2026
LourensVeen
left a comment
Contributor
There was a problem hiding this comment.
Alright, this works. One open question but no need to implement that now I think, unless it's easy and makes sense. I'll leave that to @IrisvdWerf because it's your code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
ymmsl.v0_2.resolve_timelines()before starting the simulation to ensure that timelines are connected correctly.To make this all work out, I also needed to update:
muscle_settings_inport to make these timeline annotations work.This was needed in order to connect to an O_F port of an instance without F_INIT ports: if we do not connect
muscle_settings_in, the tested component would live in the root timeline and we would not be able to connect the O_F port to an S port of the tester. By connecting themuscle_settings_inport, the tested component lives in the correct subtimeline.test_instance_idthat was not part of the Configuration.