Let buildings be passed as targetElement for ``engineApplyShaderToWorldTexture``

[PlatinMTA]

Is your feature request related to a problem? Please describe.

Yes, the wiki is wrong: targetElement argument doesnt work for buildings.

Describe the solution you'd like

Add the possibility of passing a building as a targetElement in engineApplyShaderToWorldTexture

Describe alternatives you've considered

No response

Additional context

No response

Security Policy

• I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.

[omar-o22]

I'm not sure about this, but could you try it after #4502 has been merged?

[PlatinMTA]

I'm not sure about this, but could you try it after #4502 has been merged?

I tested and nope

test_building.zip

[Xenius97]

Works fine for me on latest 1.7 nightly

[PlatinMTA]

its not working for me (v1.7-untested-25845), are you sure those arent just objects (if they were buildings they should all be red after the "applying shader for all buildings" message)

the marked ones arent red

the shader only works when you dont specify an element (thats why i apply the same shader to the same texture name but without passing the optional argument "element").

[Xenius97]

I've investigated a few hours on this, but unable to reproduce.
https://imgur.com/a/tQnYw1l

Here is my code:

local x, y, z = getElementPosition(localPlayer)
local raw = [[
	texture tex;
	technique replace {
		pass P0 {
			Texture[0] = tex;
		}
	}
]]

local buildings = {}
local tex = dxCreateRenderTarget(4, 4)
local lastUpdate = 0
local lastShaderToggle = 0
local shader = dxCreateShader(raw, 0, 0, true, "world")
dxSetShaderValue(shader, "tex", tex)

addEventHandler("onClientRender", root, function()
	local currentTime = getTickCount()
	if currentTime - lastUpdate >= 1000 then
		lastUpdate = currentTime
		dxSetRenderTarget(tex, true)
		dxDrawRectangle(0, 0, 4, 4, tocolor(math.random(0,255), math.random(0,255), math.random(0,255), 255))
		dxSetRenderTarget()
	end
	
	if currentTime - lastShaderToggle >= 1000 then
		lastShaderToggle = currentTime
		local randomBuilding = buildings[math.random(1, #buildings)]
		if randomBuilding and isElement(randomBuilding.element) then
			if not randomBuilding.hasShader then
				outputChatBox("Applying shader to building at (" .. tostring(x) .. ", " .. tostring(y) .. ", " .. tostring(z) .. ")")
				engineApplyShaderToWorldTexture(shader, "*", randomBuilding.element)
				randomBuilding.hasShader = true
			end
		end
	end
end)

for i=1,25 do
	local building = createBuilding(1337, x, y+2*i, z)
	if building then
		buildings[#buildings+1] = {element = building, hasShader = false}
	end
end

[PlatinMTA]

Tried it again on Multi Theft Auto v1.7-untested-25878... it still doesn't work

Weren't you running a custom build on the first picture you posted?

https://youtu.be/mvdi3pb-Ej0

[Xenius97]

I've tested again, on custom build works (with latest master source code) but on nightly don't.
Maybe build server misses something, or its an other issue.

gta_sa_XFBrFKrM4W.mp4

[PlatinMTA]

Still not working for me
v1.7-untested-26804

[Xenius97]

Only works in development builds, but for some reason on nightly does not.

[PlatinMTA]

Only works in development builds, but for some reason on nightly does not.

Yeah I can confirm this... also GTA San Andreas tags spawn in the debug version lmao.

[Flashmyname]

Reproduced with the same source on both sides.

Two buildings of the same model side by side, one given the shader with targetElement, the other nothing. Solid magenta pixel shader, so "applied" is unambiguous.

local a = createBuilding(3279, x, y, z)          -- gets the shader
local c = createBuilding(3279, x, y + 22, z)     -- control

for _, tex in ipairs(engineGetModelTextureNames(3279)) do
    engineApplyShaderToWorldTexture(shader, tex, a)
end

client	result
built locally from cc3b35de, Nightly config	a magenta, c unaffected
official nightly 1.7-untested-26841	neither affected

engineApplyShaderToWorldTexture returns true for all 38 texture names in both, so the building element is not being rejected, the shader just does not end up applied in the nightly.

The two are one commit apart — cc3b35de, the automated toolchain-record commit — so this is not a newer-source effect. The binaries do differ: my game_sa.dll is 1,129,472 bytes against the nightly's 1,146,224. Could someone with build-server access compare a locally built Nightly against an official one?