Fix dual-wield hip-fire arm desync - #5368
Open
MohabCodeX wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #779
When firing dual-wield weapons without aiming, remote players see the shooter's arms invert backwards. This happened because MTA treated local bone displacement vectors as world coordinates and overwrote them with zeroed vectors.
Changes:
Preserve local bone vectors during hip-fire so arms point forward naturally
Ignore zeroed akimbo target vectors on remote clients
Keep native GTA:SA aim decisions for NPCs when player data is missing
Test: https://streamable.com/57hx9l