Fix getHeatHaze reading three settings from the wrong variables - #5372
Open
Flashmyname wants to merge 1 commit into
Open
Fix getHeatHaze reading three settings from the wrong variables#5372Flashmyname wants to merge 1 commit into
Flashmyname wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMultiplayerSA::GetHeatHazedeclaresm_HeatHazeFXSpeedMinat0xC402C0, which is the random shift address, and then readssScanSizeXfrom the scan size Y variable andsScanSizeYfrom the speed max variable.DoSetHeatHazePokesin the same file writes those three to0x8D50EC,0xC40304and0xC40308.Motivation
setHeatHazefollowed bygetHeatHazedoes not round trip, so a script cannot read back what it set.Test plan
setHeatHazewith nine distinct values, thengetHeatHaze:The other six fields were already correct. Each wrong value is exactly the value of the variable the code reads by mistake.
Checklist