Skip to content

Fix test models (3) CI failure for HONDA_PRELUDE_6G - #659

Merged
mvl-boston merged 2 commits into
combined-honda-spacelabfrom
cursor/fix-test-models-ci-3a22
Aug 22, 2026
Merged

Fix test models (3) CI failure for HONDA_PRELUDE_6G#659
mvl-boston merged 2 commits into
combined-honda-spacelabfrom
cursor/fix-test-models-ci-3a22

Conversation

@mvl-boston

@mvl-boston mvl-boston commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Rebased onto latest combined-honda-spacelab with a clean two-commit history:

  1. move test_models to opendbc (move test_models to opendbc commaai/opendbc#3581) — upstream cherry-pick (unchanged)
  2. Fix test_models CI for fork openpilot layout — all fork-specific CI/test fixes squashed into one commit

Squashed changes include workflow layout fixes, log_reader.py, pytest exclusion, MLB drop, and Pilot/Ridgeline brakePressed exception.

Open in Web Open in Cursor 

@cursor
cursor Bot force-pushed the cursor/fix-test-models-ci-3a22 branch 2 times, most recently from 295bb1c to 2657f8b Compare August 22, 2026 09:39
@github-actions github-actions Bot added the can label Aug 22, 2026
@cursor
cursor Bot force-pushed the cursor/fix-test-models-ci-3a22 branch from a0bd136 to 1f79798 Compare August 22, 2026 11:12
@github-actions github-actions Bot removed the can label Aug 22, 2026
adeebshihadeh and others added 2 commits August 22, 2026 15:34
* move test_models to opendbc

* lil more

* fix model tests

* fix model test edge cases

* avoid decoding historical panda states

* revert unrelated Volkswagen change

* infer relay state from CAN traffic

* handle archived MLB routes

* scope MLB route handling

* extend relay detection window

* run model tests directly

* activate test environment

* just use panda
Adapt the upstream test_models migration for this fork's CI, which
checks out openpilot at the workspace root and opendbc in opendbc_repo/.

- Update test_models workflow to build libsafety and set PYTHONPATH
- Add tests/log_reader.py for cereal log schema when openpilot is present
- Exclude test_models.py from pytest collection
- Drop MLB handling from fork test_models (no MLB support in fork)
- Port openpilot #30443 Pilot/Ridgeline brakePressed test exception

Co-authored-by: mvl-boston <mvl-boston@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/fix-test-models-ci-3a22 branch from 4a42e3e to bad340e Compare August 22, 2026 15:35
@mvl-boston
mvl-boston marked this pull request as ready for review August 22, 2026 15:47
@mvl-boston
mvl-boston merged commit 399aa7a into combined-honda-spacelab Aug 22, 2026
10 checks passed
@mvl-boston
mvl-boston deleted the cursor/fix-test-models-ci-3a22 branch August 22, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants