chore: bump pi-sidecar to v4.1.2 - #1177
Open
myakove wants to merge 1 commit into
Open
Conversation
Bump @myk-org/pi-sidecar ^1.3.1 → ^4.1.2 (npm) and pi-sidecar-client >=1.1.0 → >=4.1.2 (PyPI). Restore libc selectors dropped by npm install. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
PR Summary by QodoBump pi-sidecar to v4.1.2 (npm + PyPI)
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
13 rules 1. Docs mismatch sidecar deps
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+2840
to
+2846
| "dependencies": { | ||
| "@earendil-works/pi-ai": "^0.81.1", | ||
| "@earendil-works/pi-coding-agent": "^0.81.1", | ||
| "acpx": "^0.8.0", | ||
| "jiti": "^2.7.0", | ||
| "protobufjs": "7.6.5" | ||
| }, |
There was a problem hiding this comment.
1. Docs mismatch sidecar deps 🐞 Bug ☼ Reliability
The updated lockfile installs @myk-org/pi-sidecar@4.1.2 without any pi-vertex-claude-named dependency in its declared dependency list, while the repo docs still state VERTEX_CLAUDE_1M is “Read by Pi SDK sidecar” for Vertex Claude support. Users following the docs may enable Vertex Claude configuration even though the shipped sidecar dependency set no longer obviously includes a Vertex-Claude provider module.
Agent Prompt
### Issue description
After upgrading `@myk-org/pi-sidecar` to `4.1.2`, the lockfile’s declared dependency set for the sidecar no longer clearly includes a Vertex Claude provider module (previously implied by a `pi-vertex-claude` dependency name), but documentation still advertises `VERTEX_CLAUDE_1M` as a supported sidecar feature.
### Issue Context
This is a major-version upgrade of the sidecar; the container’s shipped Node dependency tree is the product surface for AI-provider support. Documentation and examples should match what is actually included in `sidecar-helper`’s dependency graph.
### Fix Focus Areas
- sidecar-helper/package-lock.json[2834-2853]
- sidecar-helper/package.json[9-20]
- docs/environment-variables.md[203-220]
- docs/enabling-ai-features.md[37-43]
### What to change
Choose one of the following and make it explicit:
1. **If Vertex Claude is still supported in pi-sidecar v4**: update docs to reference the new mechanism/package name used by v4 (and remove any outdated implication that `VERTEX_CLAUDE_1M` is supported if it isn’t).
2. **If Vertex Claude is not supported anymore by default**: update docs/examples to remove `VERTEX_CLAUDE_1M` guidance (or mark it as unsupported/deprecated).
3. **If Vertex Claude support requires an additional package now**: add the required dependency explicitly in `sidecar-helper/package.json` and regenerate `package-lock.json` so the provider module is present in the shipped image.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1174
Changes
@myk-org/pi-sidecar^1.3.1→^4.1.2insidecar-helper/package.jsonpi-sidecar-client>=1.1.0→>=4.1.2inpyproject.tomlsidecar-helper/package-lock.jsonanduv.locknpm installMade with Cursor