Repository navigation
Add IsONe flag - #32
Merged
Merged
Conversation
mytkom
approved these changes
Aug 10, 2026
mytkom
left a comment
mytkom
left a comment
Owner
There was a problem hiding this comment.
Great work, thanks! Just handle two comments and you can merge it.
| ID: tt.ID, | ||
| AODFiles: tt.TrainingDataset.AODFiles, | ||
| IsONe: tt.TrainingDataset.IsONe, | ||
| IsData: false, |
Owner
There was a problem hiding this comment.
Add a comment explaining, why do you leave it like that.
| period: {minRun, maxRun}, | ||
| }, | ||
| }, nil).Once() | ||
| }, nil) |
Collaborator
Author
There was a problem hiding this comment.
Since IsONe feature is added, the method "GetRunList" is called twice, not once. It had to be removed so the test passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.