Repository navigation
Conversation
Updates iroh to 1.1, cpal to 0.18.2, and the MoQ stack to moq-net 0.2 with the API adaptations that requires.
Replaces chunks_exact with as_chunks in the sites clippy now flags, surfaced by the toolchain floor the MoQ update raises.
Moves @moq/watch to 0.5.2 and @moq/publish to 0.4.5, which follow the Rust stack from @moq/lite onto @moq/net.
CI runs npm ci, which needs a lockfile; until now it only worked because build.rs ran npm install first and created one.
That section was removed from Cargo.toml in April and the workspace has been entirely on crates.io dependencies since.
All four references still named moq-lite-03, one wire version behind the code.
Both comments claimed moq-media-dioxus is only checked weekly, but --workspace overrides default-members and every CI run already compiles it.
Adds a per-workflow, per-ref concurrency group so a new push cancels the CI and aarch64 runs it supersedes, while Release serialises instead of cancelling to avoid a half-replaced asset set.
Carries the subscriber's own preferences and resolved track info through the forwarding handshake, rejects unservable track requests instead of accepting them, and stops the new code leaking task handles and swallowing errors.
ra0x3
marked this pull request as draft
August 27, 2026 00:33
Member
|
Hi, I just merged #45, which includes these updates together with many more. Feel free to submit further PRs as you play with things! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋🏼 ,
irohfrom some P2P streaming-related work I'm considering (and just running some tests on).iroh-livemight be able to use it as a head start to get the project back up to speed :)Summary
Updates iroh and the MoQ stack to current crates.io releases.
moq-lite(moq-net)moq-muxhangmoq-nativemoq-relayweb-transport-irohirohcpal@moq/watch@moq/publishmoq-net 0.2, so they move in one commit.iroh 1.1is semver compatible and needs no source changes.iroh-gossip,iroh-ticketsandiroh-smol-kvacceptiroh ^1and are unchanged.API changes
Broadcast/BroadcastProducer/BroadcastConsumerbecamebroadcast::{Info, Producer, Consumer}, same fortrack. Aliased imports keep call sites unchanged.connect()/accept()return(Session, Driver). The driver has to be polled for the session lifetime, soiroh-moqspawns it with the session.origin::Producer::publish_broadcastis gone. The origin mints producers viacreate_broadcast(path, Route)instead of adopting an existing consumer.iroh-moqcreates the announced broadcast and forwards into it;iroh-live-relay's pull path uses the same helper.moq_mux::import::Streamis gone, split intoContainerStream(fmp4) andTrackStream(avc3). The CLI importer follows that split.hang 0.20catalog changes:VideoConfig::display_ratio_*renamed todisplay_aspect_*,jitterdropped.Tracktype no longer carries a name or derives serde, soIrohLiveExt's chat entry uses a local DTO.RemoteBroadcast::{video, video_with, video_rendition, raw_video_track, raw_audio_track, chat}.MoqSession::publishreturnsResult, since announcing can fail.Maintainer notes
moq-relay 0.14.12does not build as publishedhttp-cache-reqwest = "1.0.0-alpha.6"withdefault-features = false, features = ["manager-moka", "url-standard"].reqwest-middlewarebecame an optional dependency, so that feature set no longer enables it:Cargo.lockhere.cargo updatewill select alpha.8 again. Fixing it upstream needs an upper bound or the feature adding.Publisher disconnect regression
Caught by
publisher_drop_closes_subscriber.moq-net 0.2expects a producer to be finished explicitly, and the dynamic handler now counts as a live handle.LocalBroadcaststopped closing the broadcast, so subscribers never saw the disconnect.LocalBroadcastisClone, so a plainDropimpl would close the broadcast as soon as the first clone went away.Verification
CI green on Linux, macOS, Playwright browser E2E, and the aarch64 zigbuild.
Locally on macOS 26 with Rust 1.98:
cargo checkacross default,--all-features,--no-default-featuresclippy --all-targets --all-features -- -D warningsfmt --check@moq/hang 0.4parseshang 0.20's catalog, and browser to relay negotiatesmoq-lite-05Other commits
fix: satisfy newer-toolchain lints:moq-relay 0.14puts the floor at Rust 1.95, and that clippy flagschunks_exactwith a constant size. Pre-existing sites, but-D warningsfails without them.build: commit the relay web lockfile: CI runsnpm ci, which needs a lockfile. It only worked becausebuild.rsrannpm installfirst and created one.ci: cancel superseded runs: per workflow, per ref concurrency group.Releaseserialises instead of cancelling, since it replaces assets on the rolling release and a run killed mid upload leaves the binaries andSHA256SUMSout of sync.docs: drop the stale patch.crates-io instruction: that section was removed fromCargo.tomlin April.docs: correct the ALPN version in the docs: four references still namedmoq-lite-03.ci: correct the dioxus exclusion comments: the comments saidmoq-media-dioxusis only checked weekly, but--workspaceoverridesdefault-membersand every run already compiles it. Comment only. To fix the behaviour instead:--exclude moq-media-dioxusto the main jobs so the claim holds and pushes get faster.The ALPN stays on
moq-lite-04.moq-net 0.2prefersmoq-lite-05and still advertises 04, so this works as is. Moving to 05 breaks direct iroh peers and belongs in its own PR.