Fix App ID reuse when bundle identifier casing changes - #13
Open
Else00 wants to merge 2 commits into
Open
Conversation
Owner
|
Looks good to me on a quick glance, I will properly review and test either today or tommorow. Also, while isideload definitely needs tests, right now it has none, and it doesn't make sense to start introducing them with this PR. I will revisit adding tests to isideload as a whole later on, but for now, could you remove the tests? |
Author
|
Yeah sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple treats bundle IDs as case-insensitive, but isideload used exact string comparisons when looking up existing App IDs.
When an IPA changes an extension identifier from
OpenYoutube.ExtensiontoOpenYouTube.Extension, isideload attempts to register the same ID again, causing developer error 9401.This patch:
Validation:
cargo checkpassed for the isideload library on arm64 macOS using iLoader's locked dependencies.rustfmt --checkpassed for the modified application module.Reference: https://developer.apple.com/help/glossary/bundle-id/