Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that A and AAAA records contain exactly 4 and 16 bytes of RDATA before decoding an address. Short records currently cause a slice bounds panic (or consume bytes beyond the record when the buffer has spare capacity), while oversized records are silently accepted.
Reject invalid address record lengths and retain the existing decoding for valid records. Regression cases pass complete DNS responses through
UnmarshalMessage, including valid A/AAAA records, short records, and oversized records.Validation (Go 1.27.2, Windows/amd64):
go test -p 1 ./... -count=1,go vet -p 1 ./..., andgo build -p 1 ./....