Repository navigation
Publish v2.5.21 stable release to main - #32
Conversation
…nings for real Supervisor start
…adiness detection
…installer verification
…id lifecycle ownership deadlock
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b6ef3dca3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| $powershell = Get-CcodBootstrapPowerShellPath | ||
| $arguments = '-NoProfile -ExecutionPolicy Bypass -STA -File "' + $SupervisorPath + '" -ReadyToken ' + $ReadyToken | ||
| $arguments = @('-NoProfile', '-ExecutionPolicy', 'Bypass', '-STA', '-File', $SupervisorPath, '-ReadyToken', $ReadyToken) |
There was a problem hiding this comment.
When the user's profile path contains a space, $SupervisorPath also contains one, but passing it as an element of -ArgumentList does not preserve that argument boundary: Start-Process joins array elements with spaces, as documented under -ArgumentList. The child PowerShell process therefore parses only the prefix of the path as its -File value and never starts the supervisor, causing bootstrap/activation to fail for installations such as C:\Users\First Last\AppData\Local\...; retain explicit native quoting around $SupervisorPath when constructing the argument string.
Useful? React with 👍 / 👎.
Summary
Verification
Release: https://github.com/naipi11/CodexRemote-fix/releases/tag/v2.5.21