Skip to content

Allow negative H3 in DDH - #2026

Merged
abhisrkckl merged 1 commit into
nanograv:masterfrom
dlakaplan:ddh_negativeH3
Jul 31, 2026
Merged

abhisrkckl merged 1 commit into
nanograv:masterfrom
dlakaplan:ddh_negativeH3

Conversation

@dlakaplan

Copy link
Copy Markdown
Contributor

Partial fix of #2022

@dlakaplan

Copy link
Copy Markdown
Contributor Author

May not be needed if #2023 works.

@abhisrkckl

Copy link
Copy Markdown
Contributor

Why is this done? Isn't H3 strictly positive physically?

@dlakaplan

Copy link
Copy Markdown
Contributor Author

@vhaasteren asked for this in #2022, although he then fixed it himself in #2023. Physically it isn't meaningful but mathematically it can happen and can make for better numerical fitting results.

@abhisrkckl
abhisrkckl merged commit aefa608 into nanograv:master Jul 31, 2026
7 checks passed
@abhisrkckl

abhisrkckl commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Oops! I merged this on accident. Can you please re-open this?

@vhaasteren

Copy link
Copy Markdown
Member

Sorry @dlakaplan if I made you do double work! I filed the issue partly because I had buried my fix in a PR with other stuff. I meant to make it clearer this way

My order is things wasn't helpful, so Obviously I failed...

@dlakaplan

Copy link
Copy Markdown
Contributor Author

Sorry @dlakaplan if I made you do double work! I filed the issue partly because I had buried my fix in a PR with other stuff. I meant to make it clearer this way

My order is things wasn't helpful, so Obviously I failed...

No, the fault was mine. I get emails for issues but not PRs, so I didn't see until after I submitted this that you had fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants