feat(DDR): add Damour-Deruelle-Regular binary delay model - #2041
Draft
vhaasteren wants to merge 8 commits into
Draft
vhaasteren wants to merge 8 commits into
vhaasteren wants to merge 8 commits into
Conversation
One Damour-Deruelle delay, regularized over the full coordinate space, with convert_binary maps and general-order FBX parameters.
vhaasteren
marked this pull request as draft
September 11, 2026 04:48
# Conflicts: # src/pint/binaryconvert.py # src/pint/models/__init__.py # src/pint/models/pulsar_binary.py
vhaasteren
marked this pull request as ready for review
September 13, 2026 17:53
Fingerprint the cache in float64 and loosen wrap-level FD slop so x87 longdouble ulp jitter does not miss the batch or fail Dual-vs-FD checks.
80-bit CI failed at a DECJ:d_I_au zero-crossing because a 1e-8 deg step sits at the longdouble ulp.
vhaasteren
marked this pull request as draft
September 17, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
BINARY DDR: one Damour-Deruelle delay, regularized over the full coordinate space (through e=0)DDRPK Y): Einstein delay and ω-dot from the masses, not freeGAMMA/OMDOT.DDRKINE/DDRGEOare the physical 3D-motion terms (Shklovskii, Galactic P-dot, Cartesian Kopeikin projector withKOM,PX, frozenTGEO). This is the Kopeikin physics that DDK linearizes; it is not a straightforwardDDGR+Kcombination. So, there's only one inclination angle for Kopeikin and Shapiro:COSIFB0–FBK, to general order).convert_binarymaps ELL1/ELL1H/DD/DDS/DDH/DDK/BT <--> DDR. (optionaldrop_edot=on import from other binary models).DDRuses(M2, COSI)for Shapiro delay. The FW10 orthometric parameters are not natively fittable on purpose. However, through a tool like nltiming the transformation could be implemented and orthometric parameters could be sampled. Out of scope for this PRAfter conversion of all NG15 binaries to
DDRI get <1ns differences in residuals compared to the original par files.This is an implementation preview for discussion.
Test plan
tests/test_ddr.py,tests/test_ddr_kernel.py,tests/test_binconvert.pyDDRGEO Yand a spider with FBX