Repository navigation
Accept Tempo2 NHARM as an alias of ELL1H NHARMS - #2042
Open
shaneraphel wants to merge 1 commit into
Open
shaneraphel wants to merge 1 commit into
shaneraphel wants to merge 1 commit into
Conversation
A Tempo2 par with NHARM was unrecognized, so PINT kept the default harmonic count of 7 while Tempo2's omitted-keyword default is 4. STIGMA already aliases STIG. The default 7 is unchanged.
shaneraphel
force-pushed
the
ell1h-nharm-alias-2030
branch
from
September 16, 2026 10:34
852f2c5 to
cd0c240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2030.
PINT's ELL1H harmonic-count control is
NHARMS. Tempo2's isNHARM. CurrentintParameter(name="NHARMS")has empty aliases, so a Tempo2NHARMline is unrecognized and the count stays at PINT's default 7. Tempo2's omitted-keyword default is 4, so a shared par evaluates a different Shapiro delay with no hard error.STIGMAalready aliasesSTIG/VARSIGMAand is not rewritten. The default 7 is not changed.Unique rewrite:
Measured on dummy par-file keyword occupancy (
n_paired=3; not PTA TOAs, not Tempo2):NHARMSNHARMS(control)NHARMSNHARMNHARMSSTIGSTIGMA(control)STIGMA