CMR-11271: Fix Cascade collection delete does not delete from index-set when index is separate from small_collections - #2474
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2474 +/- ##
==========================================
+ Coverage 57.91% 57.93% +0.01%
==========================================
Files 1074 1074
Lines 74696 74714 +18
Branches 2175 2186 +11
==========================================
+ Hits 43263 43288 +25
+ Misses 29404 29381 -23
- Partials 2029 2045 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jmaeng72
requested changes
Aug 3, 2026
jmaeng72
requested changes
Aug 6, 2026
…anule index from index-set if it is a separate index and not in small_cllections
…llections-test to expect the 400 error returned because the deleted index no longer has an entry in the index-set
…lete success or ES returns a 404
…ttp status in the response
… the existing delete-index-set-indices behavior and remove its associated tests. These changes were unintentionally included and are outside the scope of the collection granule index-set cleanup.
…on-granule-index-if-exists once we confirm the status from the call to delete-granule-index is 200 or 404
…ollection-granule-index-if-exists` to be called, but verify the index-set is in the expected state.
… add a docstring for the test helper method and review and improve test descriptions
…moved the setup into the testing section and renamed to use "When...Then..." format.
jmaeng72
approved these changes
Aug 7, 2026
eereiter
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the objective?
Ensure that deleting a collection with a separate granule index also removes the corresponding mapping from the index set, avoiding recreation of deleted indexes and preventing invalid rebalancing attempts.
What are the changes?
cascade-collection-deleteto remove the index-set mapping only when ES returns 200 or 404. If the underlying index deletion in ES fails, the index-set is not updated. Added unit tests to confirm behavior.remove-collection-granule-index-if-existsto remove and persist the deletion of the of the separate granule-index mapping. It also handles missing mappings and collections included insmall_collections. Added unit tests to confirm behavior.What areas of the application does this impact?
Required Checklist
Additional Checklist