fix(evs): allow SendEventWithAppID for caller own AppId during startup - #2820
Open
philphauler wants to merge 1 commit into
Open
fix(evs): allow SendEventWithAppID for caller own AppId during startup#2820philphauler wants to merge 1 commit into
philphauler wants to merge 1 commit into
Conversation
philphauler
force-pushed
the
fix-2663-evs-illegal-appid
branch
from
August 29, 2026 14:42
d9a8083 to
742f2b4
Compare
Collaborator
|
@philphauler Thank you for your contribution. Please resolve the workflow failures. |
…tartup During cFE startup ES/EVS tasks may call SendEventWithAppID before full registration. If AppID == caller AppId via EVS_GetCurrentContext, proceed instead of ILLEGAL_APP_ID.
philphauler
force-pushed
the
fix-2663-evs-illegal-appid
branch
from
August 31, 2026 15:22
742f2b4 to
66b61e3
Compare
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
There seem to be two issues in the new startup branch. The current source contains literal backslashes in CFE_RESOURCEID_TEST_EQUAL\(callerAppId, AppID\), which will not compile. More importantly, on a caller-ID match it sets Status = CFE_SUCCESS but never routes callerAppData through the filtering/generation path, so the API reports success without emitting the event. Could the caller context be fed through the normal event path instead?
Contributor
Author
|
Onnit will fix 🫡🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2663
During cFE startup, ES/EVS tasks call SendEventWithAppID before full registration. If AppID equals caller AppId via EVS_GetCurrentContext, proceed instead of ILLEGAL_APP_ID. Prevents startup event loss.
AI Used: y - reviewed.