Repository navigation
Give each summary tally its own difference types set - #367
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #367 +/- ##
========================================
Coverage 96.95% 96.95%
========================================
Files 9 9
Lines 591 592 +1
========================================
+ Hits 573 574 +1
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danielfromearth
left a comment
There was a problem hiding this comment.
Hi @Hashim1999164, thank you for this PR! It looks clean, and I confirmed the new test is red on the pre-fix code and green after.
I'm requesting only two small consistency changes: moving the CHANGELOG entry into the existing ### Fixed section (it currently adds a second one), plus a tmp_path nit.
|
@danielfromearth both nits are in. changelog entry is under the existing Fixed section and the test uses tmp_path now. ready for another look whenever you are |
Closes #365
The three summary tally dictionaries were copied from one template with dict.copy, so they shared a single difference_types set. Each tally now comes from a small factory that builds a new dictionary and a new set.