Skip to content

Give each summary tally its own difference types set - #367

Merged
danielfromearth merged 3 commits into
nasa:developfrom
Hashim1999164:bugfix/issue-365
Sep 11, 2026
Merged

danielfromearth merged 3 commits into
nasa:developfrom
Hashim1999164:bugfix/issue-365

Conversation

@Hashim1999164

@Hashim1999164 Hashim1999164 commented Sep 4, 2026 •

Copy link
Copy Markdown

Closes #365

The three summary tally dictionaries were copied from one template with dict.copy, so they shared a single difference_types set. Each tally now comes from a small factory that builds a new dictionary and a new set.

@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.95%. Comparing base (c2a18b4) to head (21b973b).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #367   +/-   ##
========================================
  Coverage    96.95%   96.95%           
========================================
  Files            9        9           
  Lines          591      592    +1     
========================================
+ Hits           573      574    +1     
  Misses          18       18           
Flag Coverage Δ
python-3.11 96.95% <100.00%> (+<0.01%) ⬆️
python-3.12 96.95% <100.00%> (+<0.01%) ⬆️
python-3.13 96.95% <100.00%> (+<0.01%) ⬆️
python-3.14 96.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielfromearth danielfromearth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hashim1999164, thank you for this PR! It looks clean, and I confirmed the new test is red on the pre-fix code and green after.

I'm requesting only two small consistency changes: moving the CHANGELOG entry into the existing ### Fixed section (it currently adds a second one), plus a tmp_path nit.

Comment thread tests/test_comparison.py Outdated
Comment thread CHANGELOG.md Outdated
@Hashim1999164

Copy link
Copy Markdown
Author

@danielfromearth both nits are in. changelog entry is under the existing Fixed section and the test uses tmp_path now. ready for another look whenever you are

@danielfromearth
danielfromearth merged commit 900f6cf into nasa:develop Sep 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants