Repository navigation
fix(repair): show why a photo upload failed - #159
Merged
Merged
Conversation
Name expired logins and missing permissions, and include the status and server detail for other failures so a storage error can be told apart without server logs.
Deploying home with
|
| Latest commit: |
fda1c9e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://43603fcc.fuji-2ku.pages.dev |
| Branch Preview URL: | https://fix-photo-upload-error-detai.fuji-2ku.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every non-422 upload failure showed the same "上传失败，请稍后再试", so members could not tell an expired login from a storage outage.
A 401 now asks the member to sign in again, and a 403 says they lack permission. Other failures show the status and server detail, such as "上传失败（500 failed to store photos: OSS AccessDenied），请稍后再试". The storage detail depends on nbtca/Saturday#235.