Repository navigation
fix(editor): upload a WebP unchanged whenever it fits the size limit - #223
Merged
Merged
Conversation
The pixel limit also forced an encode for a 2560 px photo library download, a file that is already small. Only the byte limit decides now.
Deploying documents with
|
| Latest commit: |
d887059
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://852cf86f.documents-dq4.pages.dev |
| Branch Preview URL: | https://fix-editor-webp-passthrough.documents-dq4.pages.dev |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #216, follows #220. #220 skipped the encode only for a WebP of 1600 px or less on its long edge. The photo library's download is 2560 px, so the editor still encoded it again. Now any WebP within the 4 MB upload limit goes up unchanged. Other formats and larger files are resized and encoded as before.
Scope: CI or tooling.
pnpm run ci:lint,pnpm test -- --runandpnpm docs:buildpass. I did not test the upload in a browser, andtoWebphas no unit test.