Skip to content

fix: take the SSRF allowlist from nbycomp/oryx - #3

Open
fenech wants to merge 1 commit into
allow-ip-ranges-v26from
nby-oryx-fork
Open

fenech wants to merge 1 commit into
allow-ip-ranges-v26from
nby-oryx-fork

Conversation

@fenech

@fenech fenech commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Moves the configurable SSRF allowlist out of this repo's oryx/ copy into our ory/x fork, so this repo only carries a one-line go.mod change.

  • go.mod: github.com/ory/x => ./oryx now points at nbycomp/oryx@nby/ssrf-allowlist (78696cd): ory/x 4cf0c4d + ipx/ssrf_nby.go
  • oryx/ipx/ssrf.go reverted to upstream; ./oryx is no longer compiled in, so it can track upstream untouched
  • go.sum tidied

Behaviour (same as #2): AllowInternalDialFunc allows the prefixes in NBY_SSRF_ALLOWED_PREFIXES (comma-separated IPv4/IPv6 CIDRs), defaulting to ipx.DefaultAllowedPrefixes; an invalid value panics at startup.

Supersedes the SSRF part of #2; that PR's dependency bumps and CI changes are independent of this one.

🤖 Generated with Claude Code

Replace github.com/ory/x with nbycomp/oryx (ory/x 4cf0c4d + configurable
SSRF allowlist via NBY_SSRF_ALLOWED_PREFIXES) and revert the in-tree
oryx/ipx patch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 38374901954

Warning

No base build found for commit 0ec86a5 on allow-ip-ranges-v26.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 52.113%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 8994
Covered Lines: 4687
Line Coverage: 52.11%
Coverage Strength: 0.58 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants