test: give the Postgres test schema a letter prefix - #533
Merged
Merged
Conversation
The random schema name could start with a digit, which is not a valid unquoted identifier: DROP SCHEMA IF EXISTS 15plv fails with "trailing junk after numeric literal". Seen on PR #532 and again on main after its merge. lockTableName already has a prefix; this does the same. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
zebehringer
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The random schema name in
test/postgres/postgres-lock.test.jscan start with a digit, which Postgres rejects as an unquoted identifier (DROP SCHEMA IF EXISTS 15plv→ "trailing junk after numeric literal"). It flaked on #532 and again onmainright after that merge (run 33916982946).lockTableNameon the line above already carries a prefix; this givestestSchemaone too.A
test:commit, so it does not cut a release.🤖 Generated with Claude Code