Skip to content

Created GUI Python Script#109

Draft
jardinsys wants to merge 7 commits into
needsofmany:masterfrom
jardinsys:master
Draft

Created GUI Python Script#109
jardinsys wants to merge 7 commits into
needsofmany:masterfrom
jardinsys:master

Conversation

@jardinsys

Copy link
Copy Markdown

(Sorry this is late, I learned about this thing today. thanks for your work)

This is a python script that allows an easy interface for downloading.
Users just need to hit gui.py to make this run.

@needsofmany

Copy link
Copy Markdown
Owner

Thank you for putting this together, and especially for moving quickly while Simply Plural export access is still important.

I’m going to leave this PR open for review rather than merging it directly into master. A GUI export path is very useful for regular users, but anything that handles API tokens, private exported data, notes, avatar images, and third-party image downloads needs a careful safety pass before it becomes part of the main repository.

A few things I need to review before merge:

  • token handling and whether the token is ever displayed, logged, stored, or exposed through errors
  • whether exported data, notes, avatar files, and manifests stay local/private and out of Git
  • the image-download behavior, including first-party and third-party avatar URLs
  • hidden/bidirectional Unicode in gui.py
  • whether this belongs in scripts/python as an experimental helper first, rather than being advertised in the top-level README as a regular-user path
  • whether the PR should target dev or a feature branch instead of master

This is a helpful contribution, and I appreciate it. I want to make sure we land it in a way that protects users first.

@needsofmany

Copy link
Copy Markdown
Owner

I started reviewing this and I’m going to hold it out of master.

Before I can do a real review, please reformat scripts/python/gui.py with normal line breaks and remove the hidden/bidirectional Unicode characters GitHub is warning about. Right now the file is difficult to review safely.

I also need this moved into our normal branch flow: create a feature branch off dev, move this work there, and retarget the PR from that feature branch back into dev. We do not merge contributor work directly into master.

Since this handles API tokens, private exports, notes, friends data, avatar URLs, and image downloads, I’ll also need to review token handling, output-folder safety, request timeouts, avatar download behavior, and README wording before merge.

Given that the Simply Plural shutdown window has passed, I’m treating this as a possible experimental/archive utility rather than a supported regular-user export path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants