Repository navigation
Conversation
|
|
||
| [[data-type-uuid]] | ||
| === `UUID` | ||
| label:new[Introduced in bolt 6.1] |
There was a problem hiding this comment.
I wonder if it'd make more sense to conceptualize this as PackStream version 2 and note somewhere that Bolt < 6.1 uses PackStream v1 while Bolt ≥ 6.1 uses PackStream v2. There already is a headline reading "Version 1" on this page.
Good places to mention which PackStream version belongs to which bolt version:
There was a problem hiding this comment.
Or maybe version 1.1, would also be reasonable as this change is additive (if we go with 1.1 some driver ADRs and file names in drivers might need updating).
There was a problem hiding this comment.
Do we actually need to version packstream at all? Is it relevant to client devs, or is Bolt 6.1 enough?
| E0 55 0E 84 00 E2 9B 41 D4 A7 16 44 66 55 44 00 00 | ||
| ``` | ||
|
|
||
| ==== Unsupported Bolt Versions |
There was a problem hiding this comment.
This and the following sub-sections feel out of place. I agree that documenting this is a good idea, but maybe it should be in a separate place. Vector types also have similar fallbacks, but those are undocumented.
It's also not really a protocol spec, is it? It's an implementation detail of neo4j. Other bolt-aware servers might want to choose to reply with FAILURE instead for instance.
There was a problem hiding this comment.
I took this out since you're right its odd that it's here. I will card up a separate one to think about where the best place is since I do think its useful
|
@gjmwoods Please don't break sentences with newlines. The practice in docs is to use newlines for new sentences (i.e. after a full stop), regardless of their length. |
|
Apologies in the delay in progressing this PR. I'm waiting for Rouven to get back so we can have a more synchronous discussion on the best way to surface the UUID in the docs that makes sense. |
There was a problem hiding this comment.
We must not forget to also update
bolt-compatibility.adocmessage.adocmessage.adocto mention that starting with bolt 6.1 UUID is supported / PackStream v2/v1.1 is being used.
robsdedude
left a comment
robsdedude
left a comment
There was a problem hiding this comment.
Leaving comments from today's discussion meeting.
…n and supported bolt versions. Add section for packstream changes
Co-authored-by: Stefano <stefano.ottolenghi@neo4j.com>
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
|
This PR includes documentation updates Updated pages: |
|
@robsdedude i think we're all good here, safe to merge? |
This branch has not been deployed
4 participants
No description provided.