Repository navigation
Add PDF generation pipeline, update trigger/generate-html to latest template format - #385
Merged
Merged
Conversation
…emplate format - docs-trigger-builds.yml now dispatches both docs-generate-html.yml and the new docs-generate-pdf.yml, keeping all four push-triggering branches (dev, main, 5.x, 4.4). - docs-generate-html.yml refreshed to the latest docs-template shape: per-run publish-env resolution via workflow_dispatch inputs rather than a push-time matrix job, matching every other repo already migrated. Dropped the dead "approval granted" echo step - no GitHub Environment protection rule actually gates it. - docs-generate-pdf.yml added, calling reusable-docs-pdf-build.yml@v2 and handing off to docs-publish the same way docs-generate-html.yml already does. This docset has a real version (antora.yml), so no versionless flag.
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs-generate-pdf.yml, callingreusable-docs-pdf-build.yml@v2(same pattern as docs-getting-started and docs-template). This docset has a real version (antora.yml), so noversionlessflag is needed.docs-trigger-builds.ymlto the latest template format, dispatching bothdocs-generate-html.ymland the newdocs-generate-pdf.yml. Kept all four push-triggering branches this repo already had (dev,main,5.x,4.4).docs-generate-html.ymlto the latest shape:publish-envis resolved per-run inside the dispatched workflow viaworkflow_dispatchinputs, rather than a push-time matrix job - matching every other repo already migrated to this template.publish-htmljob's "If this step runs then approval has been granted" echo step - it wasn't gated by any real GitHub Environment protection rule (checked the repo's environments via the API: no branch/reviewer policy referencesprod), so it was dead code.Test plan
vars.DOCS_DEV_BRANCH/DOCS_PROD_BRANCHalready set correctly (dev/main) for this repo.js-yamloverride inpackage.jsonto conflict with the PDF pipeline's Antora requirement, unlike the issue hit in docs-template.docs-generate-pdf.ymlrun.