Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSDL updates matched actions by name alone, so installing
SemanticRun.Preparedcould overwriteLearningRun.Prepared, and anotherRecordcould replaceObservation.Record. Match bound actions by name, bound status and binding type; replace the same binding and remove its stale duplicates while preserving other bindings.This is a narrow repair on the exact kernel revision used by Foresight acceptance (
a40d3795), for ARN-518. Main promotion remains deferred.Validation: the regression fails on the old implementation. All 295
temper-spectests pass, including an explicit replay of the actual acceptance metadata with both scoped and full updates: every previous binding survives, incoming definitions match exactly, unrelated actions remain unchanged, and repeated updates are idempotent. Formatting, workspace Clippy with warnings denied, readability checks and the full workspace test suite all pass. The acceptance runtime and complete question-to-worlds flow still require deployment verification; this PR alone is not Foresight delivery.