Repository navigation
Fix bot e2e on staging, await room routes, guard unreadable shop answers - #39
Merged
Merged
Conversation
- The BOT_DEBUG bot account's own !fray e2e and sparring moves play again; its typed chat lines stay ignored as a chat bot. - handle() awaits every room and save route, so a throwing room gets the Worker's error answer (lint rule return-await in-try-catch). - A purchase whose 2xx answer the page can't read says it may have gone through and keeps the button off.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three follow-ups from #38.
!fray e2eon staging stopped at the bot's own moves because pixfray is inCHAT_BOTS. Programmatic plays fromrunCommandon aBOT_DEBUGsite now pass; the bot's typed lines are still ignored. Unit test reaches 18 of 18 and checks a typed line stays refused.return internal(...)sites inhandle()escaped its try/catch, so a throwing room gave a rejected fetch instead of the 503 answer. Added awaits and the oxlint ruletypescript/return-await: in-try-catch. New auth test.tests/ui.ts(one POST after two clicks).bun run check394/394,tests/ui.tsandtests/arena-browser.tspass.