Repository navigation
Stop the room alarm loop after a rematch lock expires - #41
Merged
Merged
Conversation
The tick dropped expired rematch locks in memory without marking the state changed, so the stored lock stayed. scheduleAlarm then saw a past due time and re-armed the alarm for now, about 8 times a second, until another change was saved. Production logged 164k alarms in 7 days, most from this loop.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An expired rematch lock is now saved away by the tick. Before,
expireStateremoved it in memory without settingchanged, soadvancenever wrote the state.scheduleAlarmthen read the stored lock, sawuntilin the past and calledsetAlarm(now + 1). The room woke about 8 times a second until some other change got saved.Evidence (production observability, last 7 days)
Change
server/game.ts: mark the state changed when the lock filter drops a lock.tests/channel.test.ts: a stored expired lock is gone afteralarm()and no alarm is due right away (red before the fix).docs/CONTRACTS.md: one line on the tick saving every expiry.bun run checkpasses (401 tests).