fix(context): store doc paths with forward slashes on Windows - #162
Merged
Merged
Conversation
findMarkdownFiles and readLocalDocsFiles built stored paths with path.join, which uses backslashes on Windows, so docs added there were stored as "docs\guide.md". The two repo-meta tests from #125 caught it once #159 turned on Windows CI, and main's Windows test job has been red since. Stored paths are package data, not filesystem paths, so build them with posix.join. Reading files still uses the platform join. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UX3uvgjRrv9uYuZxKjNF4o
🦋 Changeset detectedLatest commit: 35b0ec3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
moshest
marked this pull request as ready for review
September 25, 2026 02:06
Merged
moshest
pushed a commit
that referenced
this pull request
Sep 25, 2026
Releases @neuledge/context 1.2.6 -> 1.2.7 (patch). Consumes one changeset, .changeset/tidy-slashes-windows.md (patch on @neuledge/context, from #162): documentation paths are stored with forward slashes on Windows. @neuledge/registry 0.0.19 -> 0.0.20 is the automatic dependent bump for the private workspace package. Verified before merging: npm dist-tags.latest is 1.2.6 and 1.2.7 is not published yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Moshe · project thread
Before: on Windows, docs added from a folder or repo were stored with backslash paths such as
docs\guide.md. The same package built on Linux storeddocs/guide.md. Main's Windows test job has been red since #159 turned it on, because two of the repo-meta tests from #125 expect forward slashes.After: stored paths always use forward slashes, whatever the platform, and main's Windows job goes green.
How:
findMarkdownFilesandreadLocalDocsFilesnow build the stored relative path withposix.join. They still use the platformjointo read files from disk. A patch changeset is included because the change affects the published package.🤖 Generated with Claude Code
https://claude.ai/code/session_01UX3uvgjRrv9uYuZxKjNF4o
Generated by Claude Code