Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sktree/tests/test_honest_forest.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def test_sklearn_compatible_estimator(estimator, check):
"check_class_weight_classifiers",
# TODO: this is an error. Somehow a segfault is raised when fit is called first and
# then partial_fit
"check_fit_score_takes_y",
# "check_fit_score_takes_y",
]:
pytest.skip()
check(estimator)
Expand Down
18 changes: 9 additions & 9 deletions sktree/tests/test_supervised_forest.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,15 +193,15 @@ def _trunk(n, p=10, random_state=None):
)
def test_sklearn_compatible_estimator(estimator, check):
# TODO: remove when we can replicate the CI error...
if isinstance(
estimator,
(
ExtraObliqueRandomForestClassifier,
ObliqueRandomForestClassifier,
PatchObliqueRandomForestClassifier,
),
) and check.func.__name__ in ["check_fit_score_takes_y"]:
pytest.skip()
# if isinstance(
# estimator,
# (
# ExtraObliqueRandomForestClassifier,
# ObliqueRandomForestClassifier,
# PatchObliqueRandomForestClassifier,
# ),
# ) and check.func.__name__ in ["check_fit_score_takes_y"]:
# pytest.skip()
check(estimator)


Expand Down
8 changes: 4 additions & 4 deletions sktree/tree/tests/test_tree.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,10 @@ def test_pickle_splitters():
)
def test_sklearn_compatible_estimator(estimator, check):
# TODO: remove when we can replicate the CI error...
if isinstance(
estimator, (PatchObliqueDecisionTreeClassifier, ExtraObliqueDecisionTreeClassifier)
) and check.func.__name__ in ["check_fit_score_takes_y"]:
pytest.skip()
# if isinstance(
# estimator, (PatchObliqueDecisionTreeClassifier, ExtraObliqueDecisionTreeClassifier)
# ) and check.func.__name__ in ["check_fit_score_takes_y"]:
# pytest.skip()
check(estimator)


Expand Down