[nev21]

No description provided.

[Copilot]

🟡 Changes recommended

Throwing getters cause object entries/values polyfills to diverge from native error propagation, while iterator callback types omit the possible undefined fallback, allowing unsafe consumers to type-check.

2 open issues

• Include undefined in iterator callback value types · New
• Preserve throwing-getter errors in Object entry and value polyfills · New

What changed in this PR

This PR addresses #627 by making the library’s object iterators continue when a property getter throws, passing undefined to the callback for that key.

Changes:

• Share tolerant string-key iteration logic and apply equivalent handling to symbol keys.
• Resolve callback this values once and add regression coverage for getter failures, early exit, and callback behavior.
• Document the new behavior and its effect on polyObjKeys.

File	Description
lib/​test/​src/​common/​polyfills/​object.test.ts	Tests polyObjKeys with a throwing getter.
lib/​test/​src/​common/​object/​forEachOwnKeySafe.test.ts	Tests getter failures and callback context for string and symbol iteration.
lib/​test/​src/​common/​object/​for_each_key.test.ts	Tests getter failures, early exit, callback exceptions, and context.
lib/​src/​object/​forEachOwnKey.ts	Reuses string-key iteration and handles throwing symbol getters.
lib/​src/​object/​for_each_key.ts	Adds shared tolerant iteration and documents the fallback.
CHANGELOG.md	Records the getter-handling fix and affected helpers.

_{Review effort: Balanced}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.21%. Comparing base (de437fe) to head (6e49da4).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   99.19%   99.21%   +0.02%     
==========================================
  Files         180      180              
  Lines        5573     5590      +17     
  Branches     1248     1295      +47     
==========================================
+ Hits         5528     5546      +18     
+ Misses         45       44       -1     

Files with missing lines	Coverage Δ
lib/src/object/forEachOwnKey.ts	100.00% <100.00%> (+3.70%)	⬆️
lib/src/object/for_each_key.ts	100.00% <100.00%> (ø)
lib/src/polyfills/object/objKeys.ts	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[nevware21-bot]

Approved by nevware21-bot